Added `FakeStrictRedis.from_url` from 2.4.13 #29

Merged
merged 1 commit into from Sep 30, 2013

Conversation

Projects
None yet
3 participants

@doismellburning doismellburning referenced this pull request in python-beaver/python-beaver Jul 30, 2013

Closed

`StrictRedis.from_url` is better than DIY-ing it #174

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 30, 2013

Coverage Status

Changes Unknown when pulling 7f66313 on doismellburning:from_url into * on jamesls:master*.

Coverage Status

Changes Unknown when pulling 7f66313 on doismellburning:from_url into * on jamesls:master*.

@jamesls

This comment has been minimized.

Show comment
Hide comment
@jamesls

jamesls Aug 6, 2013

Owner

Thanks, as per the contributing guidelines this has to have a test before this can be merged. This should be a pretty quick test to write, so I should be able to get to this soon. Unless of course you beat me to it.

Owner

jamesls commented Aug 6, 2013

Thanks, as per the contributing guidelines this has to have a test before this can be merged. This should be a pretty quick test to write, so I should be able to get to this soon. Unless of course you beat me to it.

@jamesls jamesls merged commit 7f66313 into jamesls:master Sep 30, 2013

1 check passed

default The Travis CI build passed
Details
@doismellburning

This comment has been minimized.

Show comment
Hide comment
@doismellburning

doismellburning Sep 30, 2013

Contributor

Thanks, sorry, never quite got round to writing an appropriate test myself - cheers!

Contributor

doismellburning commented Sep 30, 2013

Thanks, sorry, never quite got round to writing an appropriate test myself - cheers!

@doismellburning doismellburning deleted the doismellburning:from_url branch Sep 30, 2013

@doismellburning

This comment has been minimized.

Show comment
Hide comment
@doismellburning

doismellburning Oct 18, 2013

Contributor

Any chance of a release including this fix please? Thanks!

Contributor

doismellburning commented Oct 18, 2013

Any chance of a release including this fix please? Thanks!

@jamesls

This comment has been minimized.

Show comment
Hide comment
@jamesls

jamesls Oct 19, 2013

Owner

0.4.1 is now out, which includes this pull request. Thanks again.

Owner

jamesls commented Oct 19, 2013

0.4.1 is now out, which includes this pull request. Thanks again.

josegonzalez added a commit to python-beaver/python-beaver that referenced this pull request Nov 4, 2013

`StrictRedis.from_url` is better than DIY-ing it
Note currently `fakeredis` doesn't support `from_url` - this is blocking
on jamesls/fakeredis#29 being merged in (I've
bumped version requirement in `tests.txt` accordingly)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment