Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Added `FakeStrictRedis.from_url` from 2.4.13 #29

Merged
merged 1 commit into from

3 participants

@doismellburning doismellburning referenced this pull request in josegonzalez/python-beaver
Closed

`StrictRedis.from_url` is better than DIY-ing it #174

@coveralls

Coverage Status

Changes Unknown when pulling 7f66313 on doismellburning:from_url into ** on jamesls:master**.

@jamesls
Owner

Thanks, as per the contributing guidelines this has to have a test before this can be merged. This should be a pretty quick test to write, so I should be able to get to this soon. Unless of course you beat me to it.

@jamesls jamesls merged commit 7f66313 into from
@doismellburning

Thanks, sorry, never quite got round to writing an appropriate test myself - cheers!

@doismellburning doismellburning deleted the branch
@doismellburning

Any chance of a release including this fix please? Thanks!

@jamesls
Owner

0.4.1 is now out, which includes this pull request. Thanks again.

@josegonzalez josegonzalez referenced this pull request from a commit in josegonzalez/python-beaver
@doismellburning doismellburning `StrictRedis.from_url` is better than DIY-ing it
Note currently `fakeredis` doesn't support `from_url` - this is blocking
on jamesls/fakeredis#29 being merged in (I've
bumped version requirement in `tests.txt` accordingly)
98dc702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 30, 2013
  1. @doismellburning
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 0 deletions.
  1. +6 −0 fakeredis.py
View
6 fakeredis.py
@@ -66,6 +66,12 @@ def clear(self):
class FakeStrictRedis(object):
+ @classmethod
+ def from_url(cls, url, db=None, **kwargs):
+ # Since we throw away most of this in `__init__`...
+ return cls(db=db)
+
+
def __init__(self, db=0, **kwargs):
if db not in DATABASES:
DATABASES[db] = _StrKeyDict()
Something went wrong with that request. Please try again.