Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract svg read & placeholder logic #74

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Abstract svg read & placeholder logic #74

merged 1 commit into from
Oct 11, 2017

Conversation

meowsus
Copy link

@meowsus meowsus commented Oct 10, 2017

Refactor placeholder method

Test

Re: #73

Abstract svg read & placeholder logic
18d30aa 
Refactor placeholder method

Test

Re: jamesmartin#73
@meowsus
Copy link
Author

meowsus commented Oct 10, 2017

@jamesmartin How's this for a start. I just threw a half hour at the thing to see if this might be the right direction in your opinion.

jamesmartin
jamesmartin approved these changes Oct 11, 2017
View reviewed changes
Copy link
Owner

@jamesmartin jamesmartin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

Thanks for getting started on this, @meowsus.

@jamesmartin jamesmartin merged commit e80fd9d into jamesmartin:master Oct 11, 2017
@meowsus meowsus mentioned this pull request Oct 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmartin jamesmartin jamesmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meowsus @jamesmartin