Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

[Bug] Long text on android fails #3

Closed
jamesmontemagno opened this issue Jun 20, 2016 · 3 comments
Closed

[Bug] Long text on android fails #3

jamesmontemagno opened this issue Jun 20, 2016 · 3 comments
Milestone

Comments

@jamesmontemagno
Copy link
Owner

Bug

Version Number of Plugin: Latest 2.0.0
Device Tested On: Android
Simulator Tested On: Android

Expected Behavior

All length of text that is passes

Actual Behavior

Fails silently

Steps to reproduce the Behavior

Send a long string over the limit.

@jamesmontemagno
Copy link
Owner Author

I am thinking we should expose a new:

public int MaxSpeechLength {get;}

Android docs:
https://developer.android.com/reference/android/speech/tts/TextToSpeech.html#getMaxSpeechInputLength()

Thoughts @aritchie

@aritchie
Copy link
Collaborator

aritchie commented Oct 8, 2016

I've sent some large tts messages that have worked fine. Curious what the max length is. As a practice, I plan to submit each sentence or phrease to a separate Speak() call.

Probably best to document max length and throw an argumentexception when it is too large

@jamesmontemagno
Copy link
Owner Author

Yeah, could do that and maybe expose it so they know

jamesmontemagno added a commit that referenced this issue Oct 11, 2016
Fix for #3 to allow users to test against max length
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants