Backward-compatible Rails 4 route mapper compatibility #54

Merged
merged 1 commit into from Jan 28, 2014

Projects

None yet

3 participants

@nilbus
Collaborator
nilbus commented Dec 20, 2013

There has been discussion in #42 of moving to a rack-based routing solution, but that has not been resolved, and Rails 4 is out now. This change would also require a major version bump, thus leaving 1.x incompatible with Rails 4.

This patch adds the required :via option for Rails >= version 4, but not for Rails 3, which does not support (nor need) :via.

@nilbus nilbus Backward-compatible Rails 4 route mapper compatibility
There has been discussion in #42 of moving to a rack-based routing
solution, but that has not been resolved, and Rails 4 is out now.
This change would also require a major version bump, thus leaving
1.x incompatible with Rails 4.

This patch adds the required :via option for Rails >= version 4,
but not for Rails 3, which does not support (nor need) :via.
abf3151
@nilbus
Collaborator
nilbus commented Dec 20, 2013

This is tested manually with Rails 4. Please test with Rails 3, though I'm confident that it will work there too.

You are correct that this deserves better automated testing, but I was not successful in my attempt to test with both a rails3 and rails4 dummy project.

@felixbuenemann
Contributor

👍 Working fine with rails 3.2.16 and 4.0.2.

@nilbus
Collaborator
nilbus commented Dec 28, 2013

@jamesotron Are we clear to merge and release this?

@felixbuenemann
Contributor

@nilbus James told me he's taking a time off from OSS until January.

@jamesotron jamesotron merged commit 62e7697 into jamesotron:master Jan 28, 2014

1 check passed

default The Travis CI build passed
Details
@jamesotron
Owner

Looks good. Thanks!

@nilbus
Collaborator
nilbus commented Jan 29, 2014

Thanks for reviewing it. Do you have an estimated timeline for your next release?

@jamesotron
Owner

I'm basically hands-off on all OSS at the moment, so just doing maintenance mode. I'll make you a collab if you want and you can get it ready for release.

@jamesotron
Owner

Turns out you are a collaborator already. Just get it ready for release and let me know when to git pull and rake release.

@nilbus
Collaborator
nilbus commented Jan 30, 2014

Will do. I'll make sure everything is ready and let you know.

@jamesotron
Owner

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment