Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PowerShell script converted from original Python2 script #5

Merged
merged 3 commits into from Jul 6, 2018

Conversation

@mcbobke
Copy link
Contributor

mcbobke commented May 7, 2018

For our work with JAMF, I was tasked with converting the JSS-LDAP-Sync Python2 script to PowerShell for ease of use in our environment. This is a direct conversion between scripting languages with some added optional logging functionality and error handling. It will require that the ActiveDirectory PowerShell module is installed, but it is likely that any Windows administrators will already have this installed.

I wanted to submit a Pull Request for this to see if it is of any use to the JAMF team to provide this for other enterprises. Please let me know if there is any additional information or changes that you would like me to provide.

Thanks for the consideration!

@brysontyrrell

This comment has been minimized.

Copy link
Member

brysontyrrell commented May 8, 2018

I like this. Could you update the Readme's "How to use this script" section? Put the existing instructions under a "Python Script" header and then instructions for yours under a "Powershell Script" header.

@mcbobke

This comment has been minimized.

Copy link
Contributor Author

mcbobke commented May 8, 2018

Yes, I'll get that updated.

@mcbobke mcbobke force-pushed the mcbobke:addingpowershell branch from 8095279 to 13284c5 May 8, 2018
- Updates under 'What does it do?' made to accommodate PowerShell script
- Added section 'PowerShell Script' to address specific instructions for that script
@mcbobke mcbobke force-pushed the mcbobke:addingpowershell branch from 13284c5 to 2d55797 May 8, 2018
@mcbobke

This comment has been minimized.

Copy link
Contributor Author

mcbobke commented May 8, 2018

Readme has been updated.

@mcbobke

This comment has been minimized.

Copy link
Contributor Author

mcbobke commented May 8, 2018

Pushed another quick change regarding checking for empty departments/buildings lists - an unexpected exception was thrown when iterating through an empty list.

@mcbobke

This comment has been minimized.

Copy link
Contributor Author

mcbobke commented May 29, 2018

Are there any other updates that I should make to this prior to merging?

@jamfit jamfit closed this Jul 6, 2018
@jamfit jamfit reopened this Jul 6, 2018
@jamfit jamfit merged commit eb5fcda into jamf:master Jul 6, 2018
@mcbobke

This comment has been minimized.

Copy link
Contributor Author

mcbobke commented Jul 6, 2018

Thanks, @jamfit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.