Added PowerShell script converted from original Python2 script #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this. Could you update the Readme's "How to use this script" section? Put the existing instructions under a "Python Script" header and then instructions for yours under a "Powershell Script" header. |
|
Yes, I'll get that updated. |
- Updates under 'What does it do?' made to accommodate PowerShell script - Added section 'PowerShell Script' to address specific instructions for that script
|
Readme has been updated. |
|
Pushed another quick change regarding checking for empty departments/buildings lists - an unexpected exception was thrown when iterating through an empty list. |
|
Are there any other updates that I should make to this prior to merging? |
ghost
closed this
ghost
merged commit
|
Thanks, @jamfit ! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
For our work with JAMF, I was tasked with converting the JSS-LDAP-Sync Python2 script to PowerShell for ease of use in our environment. This is a direct conversion between scripting languages with some added optional logging functionality and error handling. It will require that the ActiveDirectory PowerShell module is installed, but it is likely that any Windows administrators will already have this installed.
I wanted to submit a Pull Request for this to see if it is of any use to the JAMF team to provide this for other enterprises. Please let me know if there is any additional information or changes that you would like me to provide.
Thanks for the consideration!