Add new pppc keys #81
Conversation
watkyn
commented
Oct 14, 2020
watkyn
commented
- There is now an option for using the new Big Sur Authorization Key for the profile.
- Selecting one of the new keys will automatically prompt the user with an alert that it is only Big Sur compatible
- I also updated the UI to move the import button down by the save button
- Added some more unit tests
…of the xml as needed.
…andles the new key correctly
… importing and exporting
…d added unit tests
…he new Authorization key, warning them it is only Big Sur and above
…and an incomplete UI implementation of the NSSwitch for big sur.
This reverts commit 832fef1.
… add-new-pppc-keys
…s are going away from big sur mode and might lose some data.
…ill one annoying one not resolved about a fixed width, and also some content notices on the storyboard.
|
I'll have to look into why I didn't get the SwiftLint error locally... version maybe. |
|
Updated version to 1.3.0
There was a problem hiding this comment.
No glaring issues I could see, just a couple of formatting comments.
I hope we can sort out the signing issue. If we can't figure it out, it'd be good to call it out in the readme somewhere to let people know how to work around it, especially if we want less experienced developers to work on the app.
| case .on: | ||
| if model.usingLegacyAllowKey && showAlert { | ||
| let message = """ | ||
| Enabling Big Sur Compatibility will require the profile to be installed on macOS versions Big Sur (11.0) or greater. |
There was a problem hiding this comment.
Think it'd be worth using 10.16 here instead? Or 10.16/11.0?
| Enabling Big Sur Compatibility will require the profile to be installed on macOS versions Big Sur (11.0) or greater. | |
| Enabling Big Sur Compatibility will require the profile to be installed on macOS versions Big Sur (10.16) or greater. |
There was a problem hiding this comment.
Yeah, I'm not sure what to do there. I'm not a fan of Apple's conditional versioning for Big Sur.
There was a problem hiding this comment.
Maybe we could just omit the number and say "on macOS Big Sur or later".
|
So here's an interesting development: I just switched to my personal Mac, rolled back to the version before you disabled the hardened runtime, and the unit tests ran just fine. I also found another, non-Jamf Xcode project that was having the same issues. Tests hang indefinitely on my work Mac, but run just fine on my personal Mac. 🤔 |
