Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS for self signed certificates #56

Merged
merged 1 commit into from Mar 10, 2020

Conversation

radekg
Copy link
Contributor

@radekg radekg commented Mar 10, 2020

Hi @jamiealquiza. This pull request adds support for TLS with self signed certificates. In case of a self signed certificate, there will be no root ca (and thus no matching file). The new flags -tls-cert-file and -tls-key-file, together with -tls-insecure-skip-verify, allow for self-signed certificate usage.

Example:

$GOPATH/bin/sangrenel \
    -brokers=... \
    -message-batch-size=500 \
    -message-size=500 \
    -required-acks=all \
    -topic=scratch.kafka-proxy-test.dshtest \
     -tls \
     -tls-cert-file=$HOME/cert.pem \
     -tls-key-file=$HOME/key.pem \
     -tls-insecure-skip-verify

@jamiealquiza
Copy link
Owner

looks good, merging

@jamiealquiza jamiealquiza merged commit cc23db3 into jamiealquiza:master Mar 10, 2020
@radekg
Copy link
Contributor Author

radekg commented Mar 10, 2020

Wow. Cool, that was fast. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants