New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with :not( selector ) #51

Closed
EddieDhakal opened this Issue Oct 13, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@EddieDhakal

I reckon there is a little bug in :not( selector ).

For example,
----csQuery----:
CQ dom = CQ.CreateFromUrl("http://www.franchisebusiness.com.au/c/ABS-Auto-Brake-Service");
CQ items = dom.Select(".items:not(.relatedListingsContainer .items)");
int itemLength = items.Length; // itemLength = 2

----jQuery----: (I directly tested from Google Chrome's console panel):
var items = $(".items:not(.relatedListingsContainer .items)");
var itemLength = items.length; // itemLength = 0

How come "itemLength" is different on jQuery and csQuery? or How am I gonna get similar result using csQuery?

@jamietre

This comment has been minimized.

Show comment
Hide comment
@jamietre

jamietre Oct 13, 2012

Owner

Oh right.... Struck that last comment... yes, appears to be a bug. Will get it fixed soon.

Owner

jamietre commented Oct 13, 2012

Oh right.... Struck that last comment... yes, appears to be a bug. Will get it fixed soon.

jamietre added a commit that referenced this issue Oct 15, 2012

@jamietre

This comment has been minimized.

Show comment
Hide comment
@jamietre

jamietre Oct 15, 2012

Owner

Fixed in latest push. Turned out to be a pretty nasty problem, I had a fundamental implementation issue with subselectors that for some reason were not addressed in any existing test case. Glad this got found this before I released 1.3!

Owner

jamietre commented Oct 15, 2012

Fixed in latest push. Turned out to be a pretty nasty problem, I had a fundamental implementation issue with subselectors that for some reason were not addressed in any existing test case. Glad this got found this before I released 1.3!

@jamietre

This comment has been minimized.

Show comment
Hide comment
@jamietre

jamietre Oct 16, 2012

Owner

Release 1.3 now on nuget includes this fix

Owner

jamietre commented Oct 16, 2012

Release 1.3 now on nuget includes this fix

@jamietre jamietre closed this Oct 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment