Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with :not( selector ) #51

Closed
EddieDhakal opened this issue Oct 13, 2012 · 3 comments
Closed

Problem with :not( selector ) #51

EddieDhakal opened this issue Oct 13, 2012 · 3 comments
Labels
Bug

Comments

@EddieDhakal
Copy link

@EddieDhakal EddieDhakal commented Oct 13, 2012

I reckon there is a little bug in :not( selector ).

For example,
----csQuery----:
CQ dom = CQ.CreateFromUrl("http://www.franchisebusiness.com.au/c/ABS-Auto-Brake-Service");
CQ items = dom.Select(".items:not(.relatedListingsContainer .items)");
int itemLength = items.Length; // itemLength = 2

----jQuery----: (I directly tested from Google Chrome's console panel):
var items = $(".items:not(.relatedListingsContainer .items)");
var itemLength = items.length; // itemLength = 0

How come "itemLength" is different on jQuery and csQuery? or How am I gonna get similar result using csQuery?

@jamietre
Copy link
Owner

@jamietre jamietre commented Oct 13, 2012

Oh right.... Struck that last comment... yes, appears to be a bug. Will get it fixed soon.

jamietre added a commit that referenced this issue Oct 15, 2012
@jamietre
Copy link
Owner

@jamietre jamietre commented Oct 15, 2012

Fixed in latest push. Turned out to be a pretty nasty problem, I had a fundamental implementation issue with subselectors that for some reason were not addressed in any existing test case. Glad this got found this before I released 1.3!

@jamietre
Copy link
Owner

@jamietre jamietre commented Oct 16, 2012

Release 1.3 now on nuget includes this fix

@jamietre jamietre closed this Oct 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.