Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to JMeter 5.0 & add granularity params for short term test #17

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@daichi703n
Copy link

commented Jan 19, 2019

Bump to JMeter 5.0

Update JMeter 3.0 -> 5.0.

I tested it works on ubuntu-trusty, ubuntu-xenial. (on BOSH-Lite & AWS)

RMI Inserted package

JMeter 5.0 cluster requires RMI-Keystore, therefore I was create it by jmeter/bin/create-rmi-keystore.sh and inserted to package directory.
Please download rmi inserted package from here and upload to your blobstore.

https://s3-ap-northeast-1.amazonaws.com/d703n-bosh-tmp-blobs/apache-jmeter-5.0_rmi.tgz

test.sh logs

20190126_0245_jmeter-test.log

Note1: I changed log waiting time 1s -> 10s, because of poor spec, request sequence does not finish in 1s.

Note2: storm_mode/gaussian-random-timer-request.yml does not be passed... Please re-test on your environment. Failed reason is as below, caused by poor spec?

BROKEN: I found '6' occurances of '"GET /greeting/get/smurf HTTP/1.1" 200', expected '8'

Additional User Properties

Enabled to setting some properties on user.properties.

Example of use

Granularity parameter(default:60000ms) for short term test. (https://jmeter.apache.org/usermanual/generating-dashboard.html#configuration)

- name: storm
  lifecycle: errand
  jobs:
  - name: jmeter_storm
    release: jmeter-tornado
    properties:
      user_properties:
      - name: jmeter.reportgenerator.overall_granularity
        value: 10000
      - name: <some other user property>
        value: ...

@daichi703n daichi703n force-pushed the daichi703n:master branch from 37c6cd0 to 39fcaac Jan 25, 2019

@daichi703n daichi703n changed the title [add] granularity params for short term test Bump to JMeter 5.0 & add granularity params for short term test Jan 26, 2019

@jamlo

This comment has been minimized.

Copy link
Owner

commented Jan 26, 2019

thank you @daichi703n for the pull request. I'll post a review for it shortly.

@jamlo
Copy link
Owner

left a comment

@daichi703n Please see comments on the pull request code

%>
echo '<%=user_properties.join("\n")%>' > user.properties

This comment has been minimized.

Copy link
@jamlo

jamlo Jan 28, 2019

Owner

@daichi703n
I am thinking rather than adding the user properties here and only supporting one property, overall_granularity in this case, what do you think about having a separate template that renders the user.properties file.

To make it more generic, this template can render an array of the these properties, and it is up to the user to specify whatever they want.

For example, having something like this in the job properties:

user_properties:
- name: jmeter.reportgenerator.overall_granularity
  value: 30
- name: <some other user property>
  value: ...

Let me know what do you think

This comment has been minimized.

Copy link
@daichi703n

daichi703n Jan 28, 2019

Author

@jamlo
Thanks for review. I agree with you about having separate template for user_properties array. It is really I want to do.
I'll fix and test again.

This comment has been minimized.

Copy link
@daichi703n

daichi703n Feb 3, 2019

Author

@jamlo
I created user.properties.erb, and pushed. Please check.

@@ -2,6 +2,9 @@ jmeter/apache-jmeter-3.0_1.tgz:
size: 45178166
object_id: e28d6f50-1c64-41ca-6352-2dcffdbb9894
sha: 0063516826add27a49eb391e61a6a60dc8065813
jmeter/apache-jmeter-5.0_rmi.tgz:
size: 53908732
sha: 9df3ec29e6c7f64b396fbffcf1ae4c70128d6f01

This comment has been minimized.

Copy link
@jamlo

jamlo Jan 28, 2019

Owner

Thanks for the change to upgrade jmeter to version 5.
I think it will be easier for me to do the change myself as it is semi-automated from my side.

Would you mind removing the changes for upgrading jmeter from this pull request so that its only focus is the user.properties change ?

This comment has been minimized.

Copy link
@daichi703n

daichi703n Jan 28, 2019

Author

Yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.