Skip to content

Commit

Permalink
jamomalib: added missing dependency for implementations.
Browse files Browse the repository at this point in the history
  • Loading branch information
@nwolek
nwolek committed Nov 13, 2013
1 parent b491e20 commit faeaae6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Shared/jamomalib.rb
View file
Expand Up @@ -1802,7 +1802,7 @@ def generate_makefile(projectdir, projectname, forcedCompiler=NIL, path_to_modul
if project_type != "implementation"
makefile.write("install: | build_and_test\n") # if wrote a build_and_test above, install depends on it
else
makefile.write("install:\n") # if not (such as in Max externals), then it is not dependant
makefile.write("install: | lipo\n") # if not (such as in Max externals), then it is dependant on lipo
end

if max && mac?
Expand Down

6 comments on commit faeaae6

@nwolek
Copy link
Member Author

@nwolek nwolek commented on faeaae6 Nov 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tap @theod @lossius
Resolves issue discussion from previous commit #b491e20
Twin projects now build and should clear the way for merging 'unittest' and 'dev' branches.

@nwolek
Copy link
Member Author

@nwolek nwolek commented on faeaae6 Nov 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only three failed projects on this commit:
AudioUnit
j.plug.parameter#
j.ui

@lossius
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks Nathan!

@lossius
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwolek AudioUnit fails on every branch, so you don't have to be concerned with that. I'll do a fresh dev build in a little while and see bow that fares with j.plug.parameter#, j.ui builds on the dev branch.

@nwolek
Copy link
Member Author

@nwolek nwolek commented on faeaae6 Nov 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lossius I knew about AudioUnit. Just being thorough in my documentation. I hope we are close to merging this work into "dev" though.

@theod
Copy link
Member

@theod theod commented on faeaae6 Nov 15, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.