Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pt_BR translation for 3.7.0 (see jamulussoftware#1086) #1141

Merged
merged 2 commits into from Mar 1, 2021
Merged

Update pt_BR translation for 3.7.0 (see jamulussoftware#1086) #1141

merged 2 commits into from Mar 1, 2021

Conversation

melcon
Copy link
Contributor

@melcon melcon commented Feb 27, 2021

No description provided.

@hoffie hoffie mentioned this pull request Feb 27, 2021
Closed
39 tasks
hoffie
hoffie approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your work!

  • Listed in the Contributors UI window

    jamulus/src/util.cpp

    Line 499 in f9b8973

    "<p>Melcon Moraes (<a href=\"https://github.com/melcon\">melcon</a>)</p>"
  • Changes look consistent
  • No untranslated strings (except the copyright, which is fine I'd say)

src/res/translation/translation_pt_BR.ts Outdated Show resolved Hide resolved
@hoffie hoffie added this to the Release 3.7.0 milestone Feb 27, 2021
@hoffie hoffie requested a review from ann0see February 27, 2021 22:07
ann0see
ann0see requested changes Feb 28, 2021
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me too. I'd remove the comments concerning the https:// question since I doubt the tool tip is clickable

@melcon
Update translation_pt_BR.ts
74796a5 
Removing translator comments regarding https:// prefix on tooltip
@ann0see ann0see self-requested a review March 1, 2021 11:17
@ann0see ann0see merged commit 8614347 into jamulussoftware:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffie hoffie hoffie approved these changes

@ann0see ann0see ann0see approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@melcon @hoffie @ann0see