Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pl_PL app translation for 3.9.0 #2735

Merged
merged 2 commits into from Jul 23, 2022

Conversation

SeeLook
Copy link
Contributor

@SeeLook SeeLook commented Jul 17, 2022

Fixes #2697

Short description of changes

CHANGELOG:

Context: Fixes an issue?

Does this change need documentation? What needs to be documented and how?

Status of this Pull Request

What is missing until this pull request can be merged?

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones
Copy link
Collaborator

pljones commented Jul 17, 2022

Thanks!

Do we have anyone who can review this?

@ann0see
Copy link
Member

ann0see commented Jul 17, 2022

Review Checklist:

  • Translator listed in the src/util.cpp
    "<p>Tomasz Bojczuk (<a href=\"https://github.com/SeeLook\">SeeLook</a>)</p>"
  • Punctuation and spacing consistent
  • Signal words consistent ("ASIO", "Buffer")
  • App translations: No untranslated strings (grep unfinished -5 src/translation/translation_$TRANSLATION*.ts)
  • App translations: Only a single .ts file checked in (.qm in addition is also OK)

src/translation/translation_pl_PL.ts Outdated Show resolved Hide resolved
src/translation/translation_pl_PL.ts Outdated Show resolved Hide resolved
src/translation/translation_pl_PL.ts Show resolved Hide resolved
src/translation/translation_pl_PL.ts Show resolved Hide resolved
@ann0see
Copy link
Member

ann0see commented Jul 17, 2022

@ann0see ann0see requested a review from pljones July 20, 2022 21:16
@@ -2576,12 +2576,12 @@ Twój kanał został wyciszony i włączono „Wycisz mnie”. Napraw przyczynę
<message>
<location filename="../connectdlg.cpp" line="87"/>
<source>If you know the server address, you can connect to it using the Server name/Address field. An optional port number can be added after the server address using a colon as a separator, e.g. %1. The field will also show a list of the most recently used server addresses.</source>
<translation type="unfinished"></translation>
<translation>Jeżeli znasz adres adres serwera możesz podłączyć się do niego podając te dane w polu nazwa/adres serwera. Dodatkowo może być podany numer portu - po dwukropku za adresem/numerem IP, np. %1. To pole tekstowe będzie także wyświetlać listę ostatnio używanych adresów.</translation>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeżeli znasz adres adres serwera możesz podłączyć -- adres is duplicated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

</message>
<message>
<location filename="../serverdlg.cpp" line="195"/>
<source>Custom Directory address</source>
<translation type="unfinished"></translation>
<translation>Własny adres serwera zbiorczego</translation>
Copy link
Collaborator

@pljones pljones Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English doesn't contain the word "server", so this is wrong.

Please read up on the explanation around Client, Server and Directory usage within the documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can translate English word 'Directory' directly into Polish but this is very general, technical and says nothing about.
So I used Polish „Serwer zbiorczy” which describes 'Directory' more precise.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's meant to mean the same as "address book", like where you'd keep names and addresses. Nothing technical about it.

@pljones pljones added this to the Release 3.9.0 milestone Jul 22, 2022
@pljones pljones added this to Triage in Tracking (old) via automation Jul 22, 2022
@pljones pljones added the translation used by tools/create-translation-issues.sh label Jul 22, 2022
@pljones pljones moved this from Triage to Waiting on Team in Tracking (old) Jul 22, 2022
@pljones pljones moved this from Waiting on Team to Waiting Externally in Tracking (old) Jul 22, 2022
@ann0see
Copy link
Member

ann0see commented Jul 22, 2022

@pljones would you be ok with a merge of this PR despite the open comment?

@pljones
Copy link
Collaborator

pljones commented Jul 22, 2022

I'll leave it for today. If @SeeLook can fix the various references by tomorrow, we can merge. I'd rather get them consistent.

@pljones pljones mentioned this pull request Jul 23, 2022
75 tasks
@pljones pljones merged commit 5f2a67d into jamulussoftware:master Jul 23, 2022
Tracking (old) automation moved this from Waiting Externally to Done Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation used by tools/create-translation-issues.sh
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update pl_PL app translation for 3.9.0
3 participants