Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump Qt6 from 6.3.1 to 6.3.2 (Automated PR) #2846

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Sep 10, 2022

This automated Pull Request updates the used Qt6 version to version 6.3.2.

This PR was opened by the workflow Bump dependencies (create-prs)

CHANGELOG: Build: Updated bundled Qt6 to version 6.3.2

@pljones
Copy link
Collaborator

pljones commented Sep 10, 2022

Heh, the "magically only build the things that need building" check could be really vicious and only build the relevant platform

config_name: MacOS (artifacts)

when only a build config change is made. Some really hairy scripting might be needed to do it... 😁 ...

Now, I've nothing against the PR but ... does it fix anything that's broken in 3.9.0?

@ann0see
Copy link
Member

ann0see commented Sep 11, 2022

I didn't find any official release announcement for Qt 6.3.2, just https://wiki.qt.io/Qt_6.3_Release the app seems to run on macOS...

@ann0see ann0see added this to Triage in Tracking (old) via automation Sep 11, 2022
@hoffie
Copy link
Member

hoffie commented Sep 12, 2022

Blog post: https://www.qt.io/blog/qt-6.3.2-released
Release notes: https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.3.2/release-note.md

Quick scanning does not show anything special. There are multiple font rendering fixes, which sound interesting.

It's bug-fix only, but it doesn't fix any known 3.9.0 regressions.

@ann0see
Copy link
Member

ann0see commented Sep 12, 2022

So it's probably safe to merge.

@ann0see ann0see self-requested a review September 12, 2022 15:10
@pljones
Copy link
Collaborator

pljones commented Sep 12, 2022

There are multiple font rendering fixes, which sound interesting.

Mmm, I wonder if that's related to the issue @ann0see saw with #2847...

@hoffie hoffie added this to the Release 3.9.1 milestone Sep 12, 2022
@hoffie
Copy link
Member

hoffie commented Sep 12, 2022

Mmm, I wonder if that's related to the issue @ann0see saw with #2847...

Not sure, especially since it also happened on Qt5, it seems. Maybe @ann0see can test a combination of #2847 and the Qt update.

I'd take it into 3.9.1 and have set the target accordingly.
Leaving the final decision (and merge) to @pljones though.

@hoffie hoffie moved this from Triage to Waiting on Team in Tracking (old) Sep 12, 2022
Tracking (old) automation moved this from Waiting on Team to In Progress Sep 12, 2022
@pljones
Copy link
Collaborator

pljones commented Sep 12, 2022

Given the limited scope of impact and the alleged potential benefits, I'd merge.

@ann0see
Copy link
Member

ann0see commented Sep 12, 2022

Feel free to do so.

@pljones pljones merged commit 1666b79 into master Sep 12, 2022
Tracking (old) automation moved this from In Progress to Done Sep 12, 2022
@github-actions github-actions bot deleted the ci/bump-dependencies/Qt6 branch September 12, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants