New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber Data Tables do not appear in Serenity Report #14

Closed
joekeen opened this Issue Jan 18, 2017 · 5 comments

Comments

3 participants
@joekeen

joekeen commented Jan 18, 2017

We use Cucumber Data Tables with out steps.

For example (from https://cucumber.io/docs/reference#data-tables):

Given the following users exist:
  | name   | email              | twitter         |
  | Aslak  | aslak@cucumber.io  | @aslak_hellesoy |
  | Julien | julien@cucumber.io | @jbpros         |
  | Matt   | matt@cucumber.io   | @mattwynne      |

The Data Table does not appear in the description of the step in the Serenity Report.

Only:

"Given the following users exist:"

@jan-molak

This comment has been minimized.

Show comment
Hide comment
@jan-molak

jan-molak Jan 19, 2017

Owner

Hi @joekeen and thanks for reporting this issue, it seems like a bug, let me look into this.

Owner

jan-molak commented Jan 19, 2017

Hi @joekeen and thanks for reporting this issue, it seems like a bug, let me look into this.

@nbarrett

This comment has been minimized.

Show comment
Hide comment
@nbarrett

nbarrett Jan 19, 2017

Contributor

I will be curious to see how this is handled as I've never seen a data table in a serenity report before. Is this a limitation with which fields in the cucumber json are passed to the serenity reporter or that serenity itself doesn't do data tables? This is quite important actually as I like to pass data tables to my then expectations steps to create a data driven tests.

Contributor

nbarrett commented Jan 19, 2017

I will be curious to see how this is handled as I've never seen a data table in a serenity report before. Is this a limitation with which fields in the cucumber json are passed to the serenity reporter or that serenity itself doesn't do data tables? This is quite important actually as I like to pass data tables to my then expectations steps to create a data driven tests.

@jan-molak

This comment has been minimized.

Show comment
Hide comment
@jan-molak

jan-molak Jan 22, 2017

Owner

@joekeen - please update serenity-js to the latest version, which supports both DataTable and DocString arguments of cucumber steps, as per the release notes.

@nbarrett - It's just a difference between how Cucumber reports regular step variables and the special "arguments", such as DataTables and DocStrings, which need to receive some special treatment.

Many thanks for helping make Serenity/JS even better!
Jan

Owner

jan-molak commented Jan 22, 2017

@joekeen - please update serenity-js to the latest version, which supports both DataTable and DocString arguments of cucumber steps, as per the release notes.

@nbarrett - It's just a difference between how Cucumber reports regular step variables and the special "arguments", such as DataTables and DocStrings, which need to receive some special treatment.

Many thanks for helping make Serenity/JS even better!
Jan

@joekeen

This comment has been minimized.

Show comment
Hide comment
@joekeen

joekeen Jan 23, 2017

Hi @jan-molak, I have updated and now the report includes the DataTable argument as required. Thanks for your work on Serenity/JS!

joekeen commented Jan 23, 2017

Hi @jan-molak, I have updated and now the report includes the DataTable argument as required. Thanks for your work on Serenity/JS!

@jan-molak

This comment has been minimized.

Show comment
Hide comment
@jan-molak

jan-molak Jan 23, 2017

Owner

Lovely, thanks for letting me know, glad that you found it useful :-)

Owner

jan-molak commented Jan 23, 2017

Lovely, thanks for letting me know, glad that you found it useful :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment