New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis build for PRs is failing #17

Closed
InvictusMB opened this Issue Jan 18, 2017 · 1 comment

Comments

2 participants
@InvictusMB
Contributor

InvictusMB commented Jan 18, 2017

I don't know why is that happening. I suspected that I broke something with changing TS compile target for specs but it seems to fail irrespective of those changes.
So I played around for a while and created 3 separate PRs touching different areas but builds for all of them fail.
I bet the build would fail even if I change only the readme.

@jan-molak

This comment has been minimized.

Show comment
Hide comment
@jan-molak

jan-molak Jan 18, 2017

Owner

Looks like Travis CI prevents its users from running BrowserStack tests for PRs, and we can't use phantomjs for some of the tests as it doesn't support multi-select dropdowns 😞

Let me think how we can work around that.

Owner

jan-molak commented Jan 18, 2017

Looks like Travis CI prevents its users from running BrowserStack tests for PRs, and we can't use phantomjs for some of the tests as it doesn't support multi-select dropdowns 😞

Let me think how we can work around that.

@jan-molak jan-molak self-assigned this Jan 19, 2017

@jan-molak jan-molak closed this in 0fbea2d Jan 20, 2017

jan-molak added a commit that referenced this issue Jan 20, 2017

fix(ci): Travis should be able to correctly test PRs
Because of security restrictions on Travis CI, PR builds don't have access to encrypted environment

variables required for the BrowserStack local connection to work. To work around this limitation, PR

builds will now use PhantomJS instead of BrowserStack for all the tests that don't require a real

browser. The main build will execute tests using using both PhantomJS and a real browser to ensure

full coverage.

Fixes #17

jan-molak added a commit that referenced this issue Jan 20, 2017

fix(ci): Travis should be able to correctly test PRs
Because of security restrictions on Travis CI, PR builds don't have access to encrypted environment
variables required for the BrowserStack local connection to work.

To work around this limitation, PR builds will now use PhantomJS instead of BrowserStack for all the tests
that don't require a real browser.

The main build will execute tests using a real browser.

Fixes #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment