Fix bug where you can't disable the extension #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disabling the extension works.
jancborchardt
added a commit
that referenced
this pull request
Aug 30, 2012
Fix bug where you can't disable the extension
|
People like you is why I love open source. Thank you so much, especially for the good explanation! 🚀 |
|
And the fix is now up and approved: https://extensions.gnome.org/extension/393/distraction-free/ Thanks again @mathematicalcoffee ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed your bug where you can't disable the extension.
When you connect to an event via
object.connect(signal, callback);it returns an ID that you can use to disconnect that event later.So when you disconnect in
disableyou should use the same IDs that were returned when you connected inenable, not a new connection ID (which is what you are currently doing).That's why I've created some global variables
showIDandhideID, I store the ID returned fromOverview.connect, and use it to disconnect indisable.Hope that helps :) Keep up playing with extensions, it's fun!