Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPDS book search #283

Closed
kobemtl opened this issue Aug 15, 2017 · 13 comments
Closed

OPDS book search #283

kobemtl opened this issue Aug 15, 2017 · 13 comments

Comments

@kobemtl
Copy link

kobemtl commented Aug 15, 2017

Thanks a lot for the application. Love it a lot since I started using it. If its possible, it would be great to have the search feature in OPDS. or perhaps shelf category?

@OzzieIsaacs
Copy link
Collaborator

Just checked it in Marvin3 OPDS-Reader (iOS), the search is working.
Which feed reader do you use, is there an error message (if search is not possible, is is implemented in the reader?)

@idalin
Copy link
Contributor

idalin commented Aug 16, 2017

try to restart your App.
I found there is no searching after first adding opds in some App. After a restarting, it shows up.

@kobemtl
Copy link
Author

kobemtl commented Aug 16, 2017

Thanks a lot for the reply.

I am using Moon+ Reader Pro on Android.
Below you can see the search icon shows on Calibre OPDS but not Calibre-Web OPDS. My Calibre server puts behind apache reverse proxy.
Calibre OPDS: https://mydomain/calibre/opds
calibre

Calibre-Web OPDS: https://mydomain/calibre-web/opds
calibre-web

@jkrehm
Copy link
Contributor

jkrehm commented Aug 16, 2017

Might be more of an issue with Moon+ than Calibre-web. Perhaps it's looking for something specific? I use FBReader and it lets me search my library without issue.

@kobemtl
Copy link
Author

kobemtl commented Aug 16, 2017

Seems like it. I just found Moon+ not support search on Wikipedia. But how come the search works on Cablire-Server?

@jkrehm
Copy link
Contributor

jkrehm commented Aug 16, 2017

I just compared the output of Calibre's OPDS to Calibre-Web and I believe this makes the difference:

<link type="application/atom+xml" href="/opds/search/{searchTerms}?library_id=Books" title="Search" rel="search"/>

According to the spec we should be able to add that element to enable searching.

I suspect the apps us others are using just searches the XML directly.

@jkrehm
Copy link
Contributor

jkrehm commented Aug 16, 2017

D'oh, nevermind. My editor wasn't auto-wrapping the find and I failed to note Calibre-Web's

<link rel="search" title="Search" href="/opds/osd"
        type="application/opensearchdescription+xml"/>

at the top. So maybe that's not it.

@kobemtl
Copy link
Author

kobemtl commented Aug 17, 2017

maybe moon+ not supporting opensearch? Anyway this confirmed the problem is not from calibew-web. Thanks everyone.

@kobemtl kobemtl closed this as completed Aug 17, 2017
@OzzieIsaacs
Copy link
Collaborator

There are several issues with moon reader:

  • search is not working
  • covers are not shown

@OzzieIsaacs
Copy link
Collaborator

Doublechecked, search should work now, please try with the newest commit.
The covers are also not shown in calibre, it's a bug in moon reader (no login data is send in request for images). Nothing we can change easily.

@kobemtl
Copy link
Author

kobemtl commented Aug 21, 2017

Thank you so much!!! It's working now.

jkrehm added a commit to jkrehm/calibre-web that referenced this issue Aug 21, 2017
* master:
  Fix for janeczku#286
  search button is displayed in moon reader (janeczku#283), search result is not displayed
@8bitgentleman
Copy link

I recently started using moon+ with calibre-web and this still seems to be happening. Moon+ can use Calibre's default content-server search but search is not available for calibre-web's opds feed

@OzzieIsaacs
Copy link
Collaborator

I fiddles about one month ago on the search code.
My readers work, I‘m having a look at it(takes some time, as I currently without my computer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants