Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump http/client to 2.0 or add it as ^1.4 | 2.x? #59

Closed
garex opened this Issue Mar 10, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@garex
Copy link

garex commented Mar 10, 2019

Because of this weird bug in it

php-http/client-common#118

AddPathPlugin is unusable in long-running processes.

@joelwurtz

This comment has been minimized.

Copy link
Member

joelwurtz commented Mar 10, 2019

It's already done on 4.x : https://github.com/janephp/janephp/blob/4.x/composer.json (and released under the 4.2.0)

For 5.x it will only support 2.x but there is no release yet

@joelwurtz

This comment has been minimized.

Copy link
Member

joelwurtz commented Mar 10, 2019

on 4.x like i said and link :) see here : https://github.com/janephp/open-api-runtime/blob/4.x/composer.json

Master is the futur branch not ready and not released

@garex

This comment has been minimized.

Copy link
Author

garex commented Mar 10, 2019

image

Usually I expect master branch to be something latest on the edge. Ok. Will know then to look at packagist before sending issues ))

@garex garex closed this Mar 10, 2019

@joelwurtz

This comment has been minimized.

Copy link
Member

joelwurtz commented Mar 10, 2019

No problem :p it happens, but that show also that maybe i should put 4.x as the default branch ATM and not master.

@garex

This comment has been minimized.

Copy link
Author

garex commented Mar 11, 2019

Or just drop it if it's not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.