Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better testing #269

Merged
merged 5 commits into from Mar 25, 2020
Merged

Better testing #269

merged 5 commits into from Mar 25, 2020

Conversation

@Korbeil
Copy link
Member

Korbeil commented Mar 20, 2020

Instead of testing the whole component from Jane root, we should test component individually one by one.

@Korbeil Korbeil marked this pull request as ready for review Mar 20, 2020
@Korbeil Korbeil force-pushed the Korbeil:feature/better-testing branch 14 times, most recently from 2d59498 to b5a4e94 Mar 20, 2020
@Korbeil Korbeil force-pushed the Korbeil:feature/better-testing branch from b5a4e94 to 6e830c1 Mar 24, 2020
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/components-install.sh Outdated Show resolved Hide resolved
.github/workflows/components-install.sh Outdated Show resolved Hide resolved
.github/workflows/components-install.sh Outdated Show resolved Hide resolved
.github/workflows/components-install.sh Outdated Show resolved Hide resolved
.github/workflows/components-tests.sh Outdated Show resolved Hide resolved
.github/workflows/components-tests.sh Outdated Show resolved Hide resolved
src/AutoMapper/composer.json Show resolved Hide resolved
Korbeil added 2 commits Mar 24, 2020
@Korbeil Korbeil force-pushed the Korbeil:feature/better-testing branch from 1a22733 to ba2cc36 Mar 24, 2020
Korbeil added 2 commits Mar 25, 2020
@Korbeil

This comment has been minimized.

Copy link
Member Author

Korbeil commented Mar 25, 2020

So after talking with @lyrixx, testing component individually is useless unless we accept having 5.x components with 6.x components (which is not possible actually). So I removed all the stuff related to it and keep all composer & phpunit cleaning ~

@Korbeil Korbeil merged commit 4a7e353 into janephp:master Mar 25, 2020
5 checks passed
5 checks passed
cs-check
Details
tests-7.2
Details
tests-7.3
Details
tests-7.4
Details
tests-lowest
Details
@Korbeil Korbeil deleted the Korbeil:feature/better-testing branch Mar 25, 2020
@Korbeil Korbeil restored the Korbeil:feature/better-testing branch Mar 25, 2020
@Korbeil Korbeil deleted the Korbeil:feature/better-testing branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.