Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32-bit #1

Closed
wants to merge 1 commit into from
Closed

Fix 32-bit #1

wants to merge 1 commit into from

Conversation

dra27
Copy link

@dra27 dra27 commented Oct 8, 2020

Avoid the constant 0xffffffff when building 32-bit

Signed-off-by: David Allsopp <david.allsopp@metastack.com>
@stedolan
Copy link
Collaborator

stedolan commented Nov 16, 2020

I think you might have uncovered a bug here? It looks like numbers between 0x80000000 and 0xffffffff won't round-trip correctly, due to confusion between put_vint and get_vint about whether 32-bit integers are signed.

@stedolan
Copy link
Collaborator

stedolan commented Nov 16, 2020

Yep, that's a bug. Fix in #4.

@lukemaurer
Copy link
Contributor

lukemaurer commented Dec 8, 2020

Superseded by #4; closing

@lukemaurer lukemaurer closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants