This repository was archived by the owner on Jul 4, 2025. It is now read-only.
feat: redirect llamacpp log #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat-logger-update
nguyenhoangthuan99
requested review from
dan-menlo,
namchuai and
vansangpfiev
Contributor
|
Please squash the commit |
namchuai
reviewed
Sep 12, 2024
engine/controllers/server.cc
Outdated
| auto& en = std::get<EngineI*>(engines_[engine_type].engine); | ||
| if (engine_type == kLlamaEngine) { //fix for llamacpp engine first | ||
| auto config = file_manager_utils::GetCortexConfig(); | ||
| en->SetFileLogger(config.maxLogLines, config.logFolderPath + "/" + |
Contributor
There was a problem hiding this comment.
nit, IMO using std::filesystem::path is safer compare to string concatenation
dan-menlo
approved these changes
Sep 12, 2024
Contributor
dan-menlo
left a comment
dan-menlo
left a comment
There was a problem hiding this comment.
@nguyenhoangthuan99 Approved to unblock. Please also link the cortex.llamacpp PR in this, as I think they have to be read together for future users to understand.
vansangpfiev
approved these changes
Sep 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1054
related PR janhq/cortex.llamacpp#223
Sumarry changes: