From cb8f25f8fa2ad7cd1c69f89c17a9151aae985187 Mon Sep 17 00:00:00 2001 From: vansangpfiev Date: Mon, 7 Oct 2024 15:25:57 +0700 Subject: [PATCH 1/3] chore: change update to patch --- engine/controllers/models.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/engine/controllers/models.h b/engine/controllers/models.h index c2c804170..167d4bb36 100644 --- a/engine/controllers/models.h +++ b/engine/controllers/models.h @@ -14,7 +14,7 @@ class Models : public drogon::HttpController { METHOD_ADD(Models::PullModel, "/pull", Post); METHOD_ADD(Models::ListModel, "", Get); METHOD_ADD(Models::GetModel, "/{1}", Get); - METHOD_ADD(Models::UpdateModel, "/{1}", Post); + METHOD_ADD(Models::UpdateModel, "/{1}", Patch); METHOD_ADD(Models::ImportModel, "/import", Post); METHOD_ADD(Models::DeleteModel, "/{1}", Delete); METHOD_ADD(Models::SetModelAlias, "/alias", Post); @@ -24,7 +24,7 @@ class Models : public drogon::HttpController { ADD_METHOD_TO(Models::PullModel, "/v1/models/pull", Post); ADD_METHOD_TO(Models::ListModel, "/v1/models", Get); ADD_METHOD_TO(Models::GetModel, "/v1/models/{1}", Get); - ADD_METHOD_TO(Models::UpdateModel, "/v1/models/{1}", Post); + ADD_METHOD_TO(Models::UpdateModel, "/v1/models/{1}", Patch); ADD_METHOD_TO(Models::ImportModel, "/v1/models/import", Post); ADD_METHOD_TO(Models::DeleteModel, "/v1/models/{1}", Delete); ADD_METHOD_TO(Models::SetModelAlias, "/v1/models/alias", Post); From 7f0349ce36e2e42fb51c9a9631185a9ba3ee77f1 Mon Sep 17 00:00:00 2001 From: vansangpfiev Date: Mon, 7 Oct 2024 15:28:25 +0700 Subject: [PATCH 2/3] fix: swagger --- engine/controllers/swagger.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/controllers/swagger.cc b/engine/controllers/swagger.cc index 89733b65c..27d9b7b15 100644 --- a/engine/controllers/swagger.cc +++ b/engine/controllers/swagger.cc @@ -211,7 +211,7 @@ Json::Value SwaggerController::generateOpenAPISpec() { ["message"]["type"] = "string"; // UpdateModel Endpoint - Json::Value& update = spec["paths"]["/v1/models/{model}"]["post"]; + Json::Value& update = spec["paths"]["/v1/models/{model}"]["patch"]; update["summary"] = "Update model details"; update["description"] = "Update various attributes of a model based on the ModelConfig " From 8d8846d1ed41600f5e20cfb990e9c6daa5d9a75f Mon Sep 17 00:00:00 2001 From: vansangpfiev Date: Mon, 7 Oct 2024 16:57:38 +0700 Subject: [PATCH 3/3] fix: pull api --- engine/services/model_service.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/services/model_service.cc b/engine/services/model_service.cc index d9c2aa48f..1b0946133 100644 --- a/engine/services/model_service.cc +++ b/engine/services/model_service.cc @@ -310,7 +310,7 @@ cpp::result ModelService::DownloadModelFromCortexso( } std::string model_id{name + ":" + branch}; - auto on_finished = [&](const DownloadTask& finishedTask) { + auto on_finished = [&, model_id](const DownloadTask& finishedTask) { const DownloadItem* model_yml_item = nullptr; auto need_parse_gguf = true;