Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

310 bug cannot unload model on nitro 022 #311

Merged
merged 4 commits into from
Jan 3, 2024
Merged

310 bug cannot unload model on nitro 022 #311

merged 4 commits into from
Jan 3, 2024

Conversation

@tikikun
Copy link
Contributor

@tikikun tikikun commented Jan 3, 2024

No description provided.

@tikikun tikikun added the P0: critical Mission critical label Jan 3, 2024
@tikikun tikikun self-assigned this Jan 3, 2024
@tikikun tikikun linked an issue Jan 3, 2024 that may be closed by this pull request
bug: Cannot unload model on nitro 0.2.2 #310
Closed
@tikikun tikikun marked this pull request as draft January 3, 2024 07:38
@tikikun tikikun marked this pull request as ready for review January 3, 2024 07:38
@tikikun
Copy link
Contributor Author

tikikun commented Jan 3, 2024

  • What this PR will fix:
  • Fix the wrong way to include clip (in previous version need manually now it's properly specified in cmakelist of llava)
  • Fix the CV inside new llama cpp update, we can revisit this later on for a bit of extra performance, right now it's better just do busy waiting using while loop

@tikikun tikikun merged commit a87551d into main Jan 3, 2024
@hiro-v hiro-v deleted the 310-bug-cannot-unload-model-on-nitro-022 branch January 30, 2024 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@tikikun tikikun

Labels

P0: critical Mission critical

Projects

No open projects
Menlo
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Cannot unload model on nitro 0.2.2

2 participants

@tikikun