From f18741c145cbeb8a0c796bdb29972446acc3e2d5 Mon Sep 17 00:00:00 2001 From: marknguyen1302 Date: Mon, 17 Jun 2024 16:11:06 +0700 Subject: [PATCH] fix telemetry folder not exist, disable crash report --- .../repositories/telemetry/telemetry.repository.ts | 3 +++ .../services/file-manager/file-manager.service.ts | 8 ++++++++ cortex-js/src/usecases/telemetry/telemetry.usecases.ts | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/cortex-js/src/infrastructure/repositories/telemetry/telemetry.repository.ts b/cortex-js/src/infrastructure/repositories/telemetry/telemetry.repository.ts index b08882244..ee17370c0 100644 --- a/cortex-js/src/infrastructure/repositories/telemetry/telemetry.repository.ts +++ b/cortex-js/src/infrastructure/repositories/telemetry/telemetry.repository.ts @@ -102,6 +102,9 @@ export class TelemetryRepositoryImpl implements TelemetryRepository { async getLastCrashReport(): Promise { try { + await this.fileManagerService.createFolderIfNotExistInDataFolder( + 'telemetry', + ); const { data } = await this.fileManagerService.getLastLine( join(await this.getTelemetryDirectory(), this.crashReportFileName), ); diff --git a/cortex-js/src/infrastructure/services/file-manager/file-manager.service.ts b/cortex-js/src/infrastructure/services/file-manager/file-manager.service.ts index be296c751..219f48a45 100644 --- a/cortex-js/src/infrastructure/services/file-manager/file-manager.service.ts +++ b/cortex-js/src/infrastructure/services/file-manager/file-manager.service.ts @@ -230,4 +230,12 @@ export class FileManagerService { const dataFolderPath = await this.getDataFolderPath(); return join(dataFolderPath, this.benchmarkFoldername); } + + async createFolderIfNotExistInDataFolder(folderName: string): Promise { + const dataFolderPath = await this.getDataFolderPath(); + const folderPath = join(dataFolderPath, folderName); + if (!existsSync(folderPath)) { + await promises.mkdir(folderPath, { recursive: true }); + } + } } diff --git a/cortex-js/src/usecases/telemetry/telemetry.usecases.ts b/cortex-js/src/usecases/telemetry/telemetry.usecases.ts index 4b48ee617..8dbd2ecd8 100644 --- a/cortex-js/src/usecases/telemetry/telemetry.usecases.ts +++ b/cortex-js/src/usecases/telemetry/telemetry.usecases.ts @@ -29,7 +29,7 @@ export class TelemetryUsecases { ): Promise { try { const isCollectingTelemetryEnabled = process.env.CORTEX_CRASH_REPORT; - if (isCollectingTelemetryEnabled === '0') { + if (isCollectingTelemetryEnabled !== '1') { return; } const crashReport: CrashReportAttributes = this.buildCrashReport(error);