From c2d9c8a14bc7362868d808ca5638b683cbe56065 Mon Sep 17 00:00:00 2001 From: Hien To Date: Tue, 18 Jun 2024 09:45:37 +0700 Subject: [PATCH] Fix codesign windows error --- .github/workflows/cortex-cpp-build.yml | 16 +++++------- .github/workflows/nightly-build.yml | 36 +++++++++++++------------- 2 files changed, 24 insertions(+), 28 deletions(-) diff --git a/.github/workflows/cortex-cpp-build.yml b/.github/workflows/cortex-cpp-build.yml index 245828b27..a3023d18f 100644 --- a/.github/workflows/cortex-cpp-build.yml +++ b/.github/workflows/cortex-cpp-build.yml @@ -224,17 +224,13 @@ jobs: cd cortex-cpp make codesign CODE_SIGN=true DEVELOPER_ID="${{ secrets.DEVELOPER_ID }}" - - uses: nick-fields/retry@v3 - with: - retry_wait_seconds: 10 - timeout_minutes: 10 - max_attempts: 3 - command: | - cd cortex-cpp - set PATH=%PATH%;%USERPROFILE%\.dotnet\tools - make codesign CODE_SIGN=true AZURE_KEY_VAULT_URI="${{ secrets.AZURE_KEY_VAULT_URI }}" AZURE_CLIENT_ID="${{ secrets.AZURE_CLIENT_ID }}" AZURE_TENANT_ID="${{ secrets.AZURE_TENANT_ID }}" AZURE_CLIENT_SECRET="${{ secrets.AZURE_CLIENT_SECRET }}" AZURE_CERT_NAME="${{ secrets.AZURE_CERT_NAME }}" - name: Code Signing Windows + - name: Code Signing Windows if: runner.os == 'Windows' + run: | + cd cortex-cpp + set PATH=%PATH%;%USERPROFILE%\.dotnet\tools + make codesign CODE_SIGN=true AZURE_KEY_VAULT_URI="${{ secrets.AZURE_KEY_VAULT_URI }}" AZURE_CLIENT_ID="${{ secrets.AZURE_CLIENT_ID }}" AZURE_TENANT_ID="${{ secrets.AZURE_TENANT_ID }}" AZURE_CLIENT_SECRET="${{ secrets.AZURE_CLIENT_SECRET }}" AZURE_CERT_NAME="${{ secrets.AZURE_CERT_NAME }}" + - name: Package run: | diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 5a38c5646..1101b5e9b 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -219,24 +219,24 @@ jobs: cd cortex-cpp make pre-package - - name: Code Signing macOS - if: runner.os == 'macOS' - run: | - cd cortex-cpp - make codesign CODE_SIGN=true DEVELOPER_ID="${{ secrets.DEVELOPER_ID }}" - - - uses: nick-fields/retry@v3 - with: - continue_on_error: true - retry_wait_seconds: 10 - timeout_minutes: 10 - max_attempts: 3 - command: | - cd cortex-cpp - set PATH=%PATH%;%USERPROFILE%\.dotnet\tools - make codesign CODE_SIGN=true AZURE_KEY_VAULT_URI="${{ secrets.AZURE_KEY_VAULT_URI }}" AZURE_CLIENT_ID="${{ secrets.AZURE_CLIENT_ID }}" AZURE_TENANT_ID="${{ secrets.AZURE_TENANT_ID }}" AZURE_CLIENT_SECRET="${{ secrets.AZURE_CLIENT_SECRET }}" AZURE_CERT_NAME="${{ secrets.AZURE_CERT_NAME }}" - name: Code Signing Windows - if: runner.os == 'Windows' + # - name: Code Signing macOS + # if: runner.os == 'macOS' + # run: | + # cd cortex-cpp + # make codesign CODE_SIGN=true DEVELOPER_ID="${{ secrets.DEVELOPER_ID }}" + + # - uses: nick-fields/retry@v3 + # with: + # continue_on_error: true + # retry_wait_seconds: 10 + # timeout_minutes: 10 + # max_attempts: 3 + # command: | + # cd cortex-cpp + # set PATH=%PATH%;%USERPROFILE%\.dotnet\tools + # make codesign CODE_SIGN=true AZURE_KEY_VAULT_URI="${{ secrets.AZURE_KEY_VAULT_URI }}" AZURE_CLIENT_ID="${{ secrets.AZURE_CLIENT_ID }}" AZURE_TENANT_ID="${{ secrets.AZURE_TENANT_ID }}" AZURE_CLIENT_SECRET="${{ secrets.AZURE_CLIENT_SECRET }}" AZURE_CERT_NAME="${{ secrets.AZURE_CERT_NAME }}" + # name: Code Signing Windows + # if: runner.os == 'Windows' - name: Package run: |