New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackOverflowError when using field annotations with enum members. #31

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@krullert
Copy link

krullert commented Oct 4, 2017

Added a testcase (testBugAnnotationsStackOverflowError) to ReportedBugsTest for reproduction.

@krullert

This comment has been minimized.

Copy link

krullert commented Oct 5, 2017

Ive added the fix in UnitCompiler, problem was a infinite recursion due to an eager toIAnnotations call.

@krullert

This comment has been minimized.

Copy link

krullert commented Oct 5, 2017

apparently the StackOverflowError also happened on other locations (methods and constructors), added the extra fixes to the pull request.

removed eager compiler error to support constant strings in annotations.
added annotation in annotation test cases.
added support for constants in the same scope.
@oontvoo

This comment has been minimized.

Copy link
Member

oontvoo commented Oct 6, 2017

Hi, I'm not following why we need these "RuntimeRetainedAnnotationX" classes

@krullert

This comment has been minimized.

Copy link

krullert commented Oct 7, 2017

Hi @oontvoo, They are for the various testcases in the ReportedBugsTest class, there was another bug when using String values instead of enums for runtime annotations, and another bug when using direct string constants without context identifier.

@aunkrig

This comment has been minimized.

Copy link
Member

aunkrig commented Nov 9, 2017

Merged the test case. Was able to reproduce the problem.

aunkrig added a commit that referenced this pull request Nov 9, 2017

GITHUB pull request #31: StackOverflowError when using field annotati…
…ons with enum members

Merged the test case. Was able to reproduce the problem.

aunkrig added a commit that referenced this pull request Dec 27, 2017

@aunkrig

This comment has been minimized.

Copy link
Member

aunkrig commented Dec 27, 2017

I just merged your pull request... thank you for your support.
Please review my changes, because I modified yours a bit, and not all of your changes are backed by your test case.

@aunkrig aunkrig referenced this pull request Dec 27, 2017

Closed

Issue compiling annotations #36

@aunkrig

This comment has been minimized.

Copy link
Member

aunkrig commented Dec 5, 2018

Closed due to lack of responses.

@aunkrig aunkrig closed this Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment