From ecaff40cc131ad3190c138616b44f7fe5dcaebc2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nataniel=20L=C3=B3pez?= <natanielopz@gmail.com>
Date: Wed, 15 Apr 2020 15:17:42 -0300
Subject: [PATCH] Fixed async logs

---
 CHANGELOG.md             | 4 ++++
 lib/dispatcher.js        | 4 ++--
 package-lock.json        | 2 +-
 tests/dispatcher-test.js | 2 +-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8ccc73d..135a45f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+### Fixed
+- Logs for api request not awaited causing some logs not to be successfully sent
+
 ## [4.2.3] - 2020-04-03
 ### Changed
 - Dependencies updated
diff --git a/lib/dispatcher.js b/lib/dispatcher.js
index 2102196..2bb0e84 100644
--- a/lib/dispatcher.js
+++ b/lib/dispatcher.js
@@ -95,7 +95,7 @@ class Dispatcher {
 		if(this.api.shouldLogResponseBody)
 			log.response.body = omitRecursive(response.body, this.api.excludeFieldsLogResponseBody);
 
-		Log.add(this.api.session.clientCode, {
+		return Log.add(this.api.session.clientCode, {
 			entity: 'api',
 			entityId,
 			type: 'api-request',
@@ -127,7 +127,7 @@ class Dispatcher {
 
 		this._executionFinished = process.hrtime(this._executionStarted);
 
-		this._saveLog();
+		await this._saveLog();
 
 		return this.response();
 	}
diff --git a/package-lock.json b/package-lock.json
index 63caae4..1c2c7d2 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
 {
   "name": "@janiscommerce/api",
-  "version": "4.2.2",
+  "version": "4.2.3",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
diff --git a/tests/dispatcher-test.js b/tests/dispatcher-test.js
index f9ae3fa..e821cde 100644
--- a/tests/dispatcher-test.js
+++ b/tests/dispatcher-test.js
@@ -178,7 +178,7 @@ describe('Dispatcher', function() {
 		mock('logs-disabled/get', LogsDisabled);
 		mock('logs-minimal/list', LogsMinimal);
 		mock('logs-minimal/get', LogsMinimal);
-		sandbox.stub(Log, 'add');
+		sandbox.stub(Log, 'add').resolves();
 	});
 
 	afterEach(() => {