Fix breakage with file extensions not 3 or 4 chars #9

Merged
merged 1 commit into from Nov 21, 2012

Projects

None yet

2 participants

@grantovich
Contributor

I ran into an issue where attempting to attach a file with an extension that wasn't 3 or 4 characters long would fail with a "can't convert nil into String" error. I fixed this and added some test coverage to the relevant method.

@janko-m
Owner
janko-m commented Nov 21, 2012

Wow, thank you for contributing so much :)

Yeah, I forgot that people might upload things other than photos. Thanks for this.

@janko-m janko-m merged commit 396717a into janko-m:master Nov 21, 2012
@grantovich
Contributor

No problem, thank you for being responsive. =) I'm working on an internal project that required using Dropbox storage and I'm basically bringing paperclip-dropbox up to the level where it has everything we need. The change to allow using the app_folder access level is the big one, and I hope to polish it off soon.

@janko-m
Owner
janko-m commented Nov 21, 2012

Yeah, I also tend to develop my gems like this. For example, I was thinking of checking out CarrierWave, and trying to use it with Flickr, so I'll probably make a carrierwave-flickr gem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment