Speed increases, refactored parser #217

Merged
merged 13 commits into from Jun 21, 2012

Projects

None yet

3 participants

@mjackson
Collaborator
mjackson commented Jun 4, 2012

Lots of changes in this work. First of all, I rewrote the parser/compiler to encourage greater separation of responsibilities. The scanner, parser, compiler, and renderer are all completely separate now. This architecture has led to a speed increase across the board from the 0.5.0-dev version, up to 50% in some browsers. See the bechmark here.

Also, this work removes the dependency on Ruby/Rspec for running the tests. All tests are run in JavaScript now using node and the vows testing framework. This let's us run finer grained unit tests, as well as debug the code more easily when tests are running. We also have the ability to run a single spec now instead of running the entire suite every time.

@mjackson
Collaborator
mjackson commented Jun 7, 2012

@janl Was just wondering if you've had time to take a look at this work?

@janl
Owner
janl commented Jun 7, 2012

@mjijackson not at all, sorry :( I put it on the maybe list for tomorrow.

@mjackson mjackson referenced this pull request Jun 7, 2012
Closed

Compilation Process #210

@mjackson
Collaborator

Hello @janl! Some coworkers and I were wondering earlier today if you've got any objection to me merging this work? We've been using it for the past few weeks now without any issues. Sorry, I hate to be a bother...

@janl
Owner
janl commented Jun 20, 2012

Go for it :)

@mjackson mjackson merged commit 72971b3 into janl:master Jun 21, 2012
@harrigan

Was the streaming documentation intentionally removed here?

Collaborator

Yes. There never really was any streaming going on, just a callback that was executed synchronously as new pieces were rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment