Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor parseTemplate(). address #411 #527

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@srrvnn
Copy link

srrvnn commented Nov 1, 2015

hello. first attempt to contribute. refactored parseTemplate and moved out some statements into their own function. had to scope the arrays, hasTag, and nonSpace outside parseTemplate to be shared with parseTemplateBetweenTags. would be happy to modify.

@srrvnn

This comment has been minimized.

Copy link
Author

srrvnn commented Nov 5, 2015

@dasilvacontin thoughts?

@dasilvacontin

This comment has been minimized.

Copy link
Collaborator

dasilvacontin commented Nov 6, 2015

Hi @srrvnn – thanks for the PR! Sorry, I'm quite busy. Looks good overall, but I'll take a closer look this weekend. Cheers!

@Siilwyn

This comment has been minimized.

Copy link

Siilwyn commented Feb 6, 2016

Looking good, this makes the parseTemplate function a tad more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.