Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CssUrlFilter fix #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CssUrlFilter fix #97

wants to merge 1 commit into from

Conversation

tomasnikl
Copy link

return default css code if absolutizeUrl() failed

@fprochazka
Copy link
Collaborator

Can you elaborate please? Or write a test? When does it fail?

@juniwalk
Copy link

@fprochazka I have AdminLTE.min.css in webloader with url fixed and it completely destroys the file, it is empty, this fix is needed.

//EDIT: I tested webloader with this code and it works.

@fprochazka
Copy link
Collaborator

That's cool, but I need a testcase for it. Either I write it, which might take months till I have time for it, or you guys do it :)

@juniwalk do you think you could please try to isolate the problem and write a test? Are we sure this isn't some regex platform limit problem like those errors with latte/neon ?

@juniwalk
Copy link

@fprochazka Well I can try, but I'd have to open new pull since I can't commit to this one, can I?

@fprochazka
Copy link
Collaborator

@juniwalk I don't think thats a problem, is it? You can simply cherrypick this commit to your PR.

@juniwalk
Copy link

I am probably just looking into details, I will try to look where the problem lies tomorrow.

@juniwalk
Copy link

@fprochazka So in AdminLTE.css there is @import url(https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600,700,300italic,400italic,600italic); on first line, if I remove it, the CSS is filtered normally.

// EDIT: If I just add quotes it works too, looks like missing quotes is the bottleneck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants