Jan Odvarko janodvarko

Organizations

@firebug
janodvarko commented on pull request firebug/firebug#7904
@janodvarko

Thanks Simon for the patch. Honza

@janodvarko
janodvarko merged pull request firebug/firebug#7904
@janodvarko
Fix Events panel breakage
1 commit with 1 addition and 1 deletion
@janodvarko

This option is important. We should somehow make sure that users that have the inspector installed (and not using it atm) are not having any perfor…

janodvarko commented on pull request firebug/rdp-inspector#38
@janodvarko

Sounds good, release done, https://github.com/firebug/rdp-inspector/releases/tag/rdpinspector-1.0.4 (also uploaded on AMO and waiting for review) H…

@janodvarko
janodvarko commented on pull request firebug/rdp-inspector#38
@janodvarko

@rpl: are you planning some other work on the inspector atm? Or should I release new version and ask for review on AMO? Honza

@janodvarko
janodvarko commented on pull request firebug/rdp-inspector#38
@janodvarko

Works great, Luca! Honza

@janodvarko
janodvarko merged pull request firebug/rdp-inspector#38
@janodvarko
Feature: save and load packets store
7 commits with 268 additions and 8 deletions
@janodvarko
Load and save actions
@janodvarko
test
janodvarko commented on pull request firebug/rdp-inspector#38
@janodvarko

One more thing, when I apply the patch (the two related commits) the vertical splitter for the side bar is gone. Honza

janodvarko commented on pull request firebug/rdp-inspector#38
@janodvarko

Awesome! I have merged #35 See my inline comments Honza

@janodvarko

Just like above, we shouldn't use titles, rather some kind of ID. Honza

@janodvarko

This could fail if the extension is localized. Honza

@janodvarko

I think we should use standard Open/Save file dialog (nsIFilePicker) to have better user experience - you can see PixelPerfect for an 'open' exampl…

@janodvarko

All UI strings should be localized using Locale.$STR() API Btw. the "Options" button needs localization too (can be done as a follow up). Honza

@janodvarko

Nit: please use a new line between define and "use strict" Honza

@janodvarko
@janodvarko
@janodvarko
janodvarko commented on pull request firebug/rdp-inspector#35
@janodvarko

Looks good, thanks! Honza

@janodvarko
janodvarko merged pull request firebug/rdp-inspector#35
@janodvarko
Testing: test unit React Components using karma and jasmine
18 commits with 22,098 additions and 55 deletions
@janodvarko
  • @janodvarko 75aef02
    Markup view customization (bug 1036949)
@janodvarko
Packet filtering should be case insensitive