Skip to content

Loading…

Escape should not URL encode the underscore character #7

Merged
merged 1 commit into from

2 participants

@wjlroe

Bucket and key names were having the '' character escaped. This is incorrect and inconsistent with other Riak client libraries. I have added '' to the list of unescaped characters.

@bos bos merged commit 824808b into janrain:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 7, 2011
  1. @wjlroe
Showing with 2 additions and 2 deletions.
  1. +1 −1 riak.cabal
  2. +1 −1 src/Network/Riak/Escape.hs
View
2 riak.cabal
@@ -1,5 +1,5 @@
name: riak
-version: 0.6.0.0
+version: 0.6.0.1
synopsis: A Haskell client for the Riak decentralized data store
description:
A Haskell client library for the Riak decentralized data
View
2 src/Network/Riak/Escape.hs
@@ -100,7 +100,7 @@ escapeWord8 acc i
| otherwise = acc `mappend` hex i
where
literal w = w >= 97 && w <= 122 || w >= 65 && w <= 90 ||
- w >= 48 && w <= 57 || w `B.elem` "$-.!*'(),"
+ w >= 48 && w <= 57 || w `B.elem` "$-.!*'(),_"
hex w = fromWord8 37 `mappend` d (w `shiftR` 4) `mappend` d (w .&. 0xf)
d n | n < 10 = fromWord8 (n + 48)
| otherwise = fromWord8 (n + 87)
Something went wrong with that request. Please try again.