Adding tests #9

rmoriz opened this Issue May 3, 2012 · 2 comments


None yet
2 participants

rmoriz commented May 3, 2012

How about adding tests?


janschejbal commented May 6, 2012

As you correctly pointed out in issue #10, the code does not provide APIs that would be very suitable for testing. Manual testing was done when the functions were created and after changes; I doubt automated tests would be worth the significant effort required for them. Remember that I do not expect any significant changes anymore (which is where automated tests would be most useful, to detect regressions).

@janschejbal janschejbal closed this May 6, 2012

rmoriz commented May 7, 2012

  1. An OpenID-provider is per se an API-provider. The user-interface is a kind of an API, too (can easily be tested with e.g. => Selenium, Capybara)
  2. As you already pointed out there is no way to prevent this code from having regressions in the future.

Imho: I really appreciate your work and your invested time to bring such a critcial and imho needed infrastructure service into production BUT I also think this is too important to skip tests and stick by the current architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment