Minor edit to error handling #1

Merged
merged 2 commits into from Sep 6, 2012

Conversation

Projects
None yet
2 participants
@existentialism
Contributor

existentialism commented Sep 6, 2012

During testing, we saw cases where response was undefined on error, and would subsequently break when trying to check if statusCode wasn't 200.

This change got us going again!

@jansepar

This comment has been minimized.

Show comment Hide comment
@jansepar

jansepar Sep 6, 2012

Owner

Thanks for the pull! This gives me incentive to DRY up the code a bit. Shouldn't have to make the exact same change over 9 lines :). Cheers!

Owner

jansepar commented Sep 6, 2012

Thanks for the pull! This gives me incentive to DRY up the code a bit. Shouldn't have to make the exact same change over 9 lines :). Cheers!

jansepar added a commit that referenced this pull request Sep 6, 2012

Merge pull request #1 from existentialism/master
Minor edit to error handling

@jansepar jansepar merged commit 983a23b into jansepar:master Sep 6, 2012

@existentialism

This comment has been minimized.

Show comment Hide comment
@existentialism

existentialism Sep 6, 2012

Contributor

Yeah, I'll pull out more refactors/tests we added to the code as well. Thanks again for the code, helped us out tremendously!

Contributor

existentialism commented Sep 6, 2012

Yeah, I'll pull out more refactors/tests we added to the code as well. Thanks again for the code, helped us out tremendously!

@jansepar

This comment has been minimized.

Show comment Hide comment
@jansepar

jansepar Sep 6, 2012

Owner

No problem, glad it could be of help :)

Owner

jansepar commented Sep 6, 2012

No problem, glad it could be of help :)

kub1x pushed a commit that referenced this pull request Jun 21, 2017

Merge pull request #1 from duanemay/master
Extended your view support to add an update_view command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment