Adding suport to stop build api #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| callback(error, response); | ||
| return; | ||
| } | ||
| var data = "job is stoped"; |
|
Would be great to add this command to the README! |
|
@jansepar |
| @@ -78,6 +79,19 @@ var init = exports.init = function(host, options) { | |||
| callback(null, data); | |||
| }); | |||
| }, | |||
| stopBuild: function(jobname, buildNumber, callback) { | |||
There was a problem hiding this comment.
Could this match the format of other commands and variable using the _ to denote spaces? So stopBuild → stop_build? Obviously up to @jansepar, but it looks weird to mix formats to me.
There was a problem hiding this comment.
@brianmichel bd015e0 fix this. thank you.
|
Hey @jansepar what's going on with this PR, can it be merged? |
|
Hi guys, sorry for the delay on this, it's looking good thanks! 👍 |
jansepar
added a commit
that referenced
this pull request
Apr 20, 2015
Adding suport to stop build api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.