From 23a4f92dcd7477fccc4b298d633590fde6a4b4f7 Mon Sep 17 00:00:00 2001 From: Jason Antman Date: Sat, 2 Dec 2017 11:46:20 -0500 Subject: [PATCH] fixes #314 - update RDS "DB snapshots per user" and "Subnet Groups" limit default values --- CHANGES.rst | 5 ++--- awslimitchecker/services/rds.py | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index 6cc3dc41..dde29e30 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -8,12 +8,11 @@ Unreleased Changes Python 2.6 reached its end of life in `October 2013 `_. Python 3.3 officially reached its end of life in `September 2017 `_, five years -after development was ceased. The test framework used by awslimitchecker, pytest, has `dropped support `_ for Python 2.6 and 3.3 in its latest release. According to the `PyPI download statistics `_ (which unfortunately don't take into account mirrors or caching proxies), awslimitchecker has only ever had one download reported as Python 3.3 and has a very, very small number reporting as Python 2.6 (likely only a handful of users). - -**The next release of awslimitchecker will officially drop support for Python 2.6 and 3.3**, changing the required Python version to 2.7 or >= 3.4. If you are one of the very few (perhaps only one) users running on Python 2.6, you can either run with a newer Python version or see `Issue 301 `_ for information on building a Docker container based on Python 3.5. +after development was ceased. The test framework used by awslimitchecker, pytest, has `dropped support `_ for Python 2.6 and 3.3 in its latest release. According to the `PyPI download statistics `_ (which unfortunately don't take into account mirrors or caching proxies), awslimitchecker has only ever had one download reported as Python 3.3 and has a very, very small number reporting as Python 2.6 (likely only a handful of users). **The next release of awslimitchecker will officially drop support for Python 2.6 and 3.3**, changing the required Python version to 2.7 or >= 3.4. If you are one of the very few (perhaps only one) users running on Python 2.6, you can either run with a newer Python version or see `Issue 301 `_ for information on building a Docker container based on Python 3.5. * Fix test failures caused by dependency updates. * Pin ``pytest`` development to 3.2.5 to continue python 2.6 and 3.3 support. +* `Issue #314 `_ - Update RDS service default limits; ``DB snapshots per user`` default limit increased from 50 to 100 and ``Subnet Groups`` limit increased from 20 to 50. This should not have affected any users, as these limits are retrieved in realtime via the RDS API. 2.0.0 (2017-10-12) ------------------ diff --git a/awslimitchecker/services/rds.py b/awslimitchecker/services/rds.py index 60e25206..b99bbf24 100644 --- a/awslimitchecker/services/rds.py +++ b/awslimitchecker/services/rds.py @@ -168,7 +168,7 @@ def get_limits(self): limits['DB snapshots per user'] = AwsLimit( 'DB snapshots per user', self, - 50, + 100, self.warning_threshold, self.critical_threshold, limit_type='AWS::RDS::DBSnapshot', @@ -200,7 +200,7 @@ def get_limits(self): limits['Subnet Groups'] = AwsLimit( 'Subnet Groups', self, - 20, + 50, self.warning_threshold, self.critical_threshold, limit_type='AWS::RDS::DBSubnetGroup',