New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EFS limits #358

Closed
yevgen87 opened this Issue Aug 27, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@yevgen87

yevgen87 commented Aug 27, 2018

Current EFS limits

https://docs.aws.amazon.com/efs/latest/ug//limits.html#limits-efs-resources-per-account-per-region

version

awslimitchecker 5.0.0

The required changes:

$ git diff 3ba39a5cf73ee61e3ca58f65885ff66066f126d4 294e62a1352fd015519874814d67ef53a1c7fdfa
diff --git a/awslimitchecker/services/efs.py b/awslimitchecker/services/efs.py
index 0250659..f2bcfb3 100644
--- a/awslimitchecker/services/efs.py
+++ b/awslimitchecker/services/efs.py
@@ -98,10 +98,12 @@ class _EfsService(_AwsService):
         if self.limits != {}:
             return self.limits
         limits = {}
+        self.connect()
+        region_name = self.conn._client_config.region_name
         limits['File systems'] = AwsLimit(
             'File systems',
             self,
-            10,
+            70 if region_name == 'us-east-1' else 125,
             self.warning_threshold,
             self.critical_threshold,
             limit_type='AWS::EFS::FileSystem',

@yevgen87 yevgen87 closed this Aug 27, 2018

@yevgen87 yevgen87 reopened this Aug 27, 2018

@jantman

This comment has been minimized.

Show comment
Hide comment
@jantman

jantman Aug 27, 2018

Owner

Thanks for bringing my attention to this. I'm not sure how soon I'll be able to get around to fixing this and cutting a new release, but a PR would probably help that.

In the mean time, the documentation provides information on how to override limits via either the CLI or the Python API.

Owner

jantman commented Aug 27, 2018

Thanks for bringing my attention to this. I'm not sure how soon I'll be able to get around to fixing this and cutting a new release, but a PR would probably help that.

In the mean time, the documentation provides information on how to override limits via either the CLI or the Python API.

@jantman jantman referenced this issue Sep 23, 2018

Merged

Issues/358 #360

jantman added a commit that referenced this issue Sep 23, 2018

@jantman

This comment has been minimized.

Show comment
Hide comment
@jantman

jantman Sep 23, 2018

Owner

This has been fixed in #360 and will be released shortly.

Owner

jantman commented Sep 23, 2018

This has been fixed in #360 and will be released shortly.

@jantman jantman closed this in 150e74e Sep 23, 2018

@jantman

This comment has been minimized.

Show comment
Hide comment
@jantman

jantman Sep 23, 2018

Owner

This has been released in 5.1.0 and is now live on PyPI. Thanks so much!

Owner

jantman commented Sep 23, 2018

This has been released in 5.1.0 and is now live on PyPI. Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment