Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOFORN - Limits for ALBs and Classic LBs are now provided separately #414

merged 1 commit into from Aug 13, 2019


Copy link

commented Aug 6, 2019

Before submitting pull requests, please see the
Development documentation
and specifically the Pull Request Guidelines.

IMPORTANT: Please take note of the below checklist, especially the first three items.


This PR adds support for limits for ALBs and Classic LBs are now provided separately. See #412 for more details.

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • Whether or not your PR includes unit tests:
    • Please make sure you have run the exact code contained in the PR locally, and it functions as desired.
    • Please make sure the TravisCI build passes or, if not, you've corrected any obvious problems identified by the tests.
  • Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, that's fine, just mention that in the summary and either
      ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
      include complete test coverage will usually be merged faster.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • Connections to the AWS services should only be made by the class's
      connect() and connect_resource() methods, inherited from
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

@vincentclee vincentclee force-pushed the vincentclee:issues/412 branch from c3ddd17 to c8b9e0f Aug 7, 2019


This comment has been minimized.

Copy link

commented Aug 8, 2019

This looks good to me, @vincentclee , thanks so much! I just need to give it a manual test to confirm and then I'll get it merged.

The TravisCI test failures are due to a change in pytest 5.0 which was recently released. I'll get that fixed in the develop branch once this is merged.


This comment has been minimized.

Copy link

commented Aug 13, 2019

Thanks so much for this. Merging now, I'll fix the build error in the develop branch. Hopefully I'll get a release out this afternoon.

@jantman jantman merged commit 159921e into jantman:develop Aug 13, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed

This comment has been minimized.

Copy link

commented Aug 13, 2019

This has been released in 7.0.0 and is now live on PyPI. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.