Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/419 #425

Merged
merged 13 commits into from Sep 6, 2019

Conversation

@jantman
Copy link
Owner

commented Sep 6, 2019

Summary

This PR implements the alerting/notification subsystem described in #419 along with the first alert provider, PagerDutyV1.

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • Whether or not your PR includes unit tests:
    • Please make sure you have run the exact code contained in the PR locally, and it functions as desired.
    • Please make sure the TravisCI build passes or, if not, you've corrected any obvious problems identified by the tests.
  • Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, that's fine, just mention that in the summary and either
      ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
      include complete test coverage will usually be merged faster.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • Connections to the AWS services should only be made by the class's
      connect() and connect_resource() methods, inherited from
      awslimitchecker.connectable.Connectable
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.
@codecov-io

This comment has been minimized.

Copy link

commented Sep 6, 2019

Codecov Report

Merging #425 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #425    +/-   ##
=======================================
  Coverage      100%   100%            
=======================================
  Files           33     36     +3     
  Lines         2444   2610   +166     
  Branches       366    396    +30     
=======================================
+ Hits          2444   2610   +166
Impacted Files Coverage Δ
awslimitchecker/alerts/dummy.py 100% <100%> (ø)
awslimitchecker/alerts/pagerdutyv1.py 100% <100%> (ø)
awslimitchecker/runner.py 100% <100%> (ø) ⬆️
awslimitchecker/utils.py 100% <100%> (ø) ⬆️
awslimitchecker/alerts/base.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7482079...43b20cb. Read the comment docs.

@jantman

This comment has been minimized.

Copy link
Owner Author

commented Sep 6, 2019

Verified this functionality locally as well, using a real account and real PagerDuty services.

@jantman jantman merged commit 9891db5 into develop Sep 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jantman jantman deleted the issues/419 branch Sep 6, 2019

@jantman jantman referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.