New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in git requirements #113

Closed
jantman opened this Issue Aug 30, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@jantman
Owner

jantman commented Aug 30, 2017

Right now for OFX support we require two dependencies to be installed via git, because upstream either isn't handling PRs, or isn't cutting releases (see #84 and #90 ). Unless they've been released on pypi, look into vendoring-in those packages for now (and how I'd go about distributing them with the disparate licenses?? Or, I guess that shouldn't matter since they're probably permissively licensed).

@jantman

This comment has been minimized.

Show comment
Hide comment
@jantman

jantman Oct 11, 2017

Owner

Also be sure to:

  • exempt vendored-in requirements from code coverage
  • update the install instructions and the Dockerfile
Owner

jantman commented Oct 11, 2017

Also be sure to:

  • exempt vendored-in requirements from code coverage
  • update the install instructions and the Dockerfile

@jantman jantman added in progress and removed ready labels Oct 12, 2017

jantman added a commit that referenced this issue Oct 12, 2017

jantman added a commit that referenced this issue Oct 12, 2017

jantman added a commit that referenced this issue Oct 12, 2017

@jantman jantman self-assigned this Oct 12, 2017

@jantman jantman closed this in #120 Oct 12, 2017

jantman added a commit that referenced this issue Oct 12, 2017

Merge pull request #120 from jantman/issues/113
Fixes #113 - vendor-in git requirements

@jantman jantman removed the in progress label Oct 12, 2017

@jantman jantman reopened this Oct 12, 2017

@jantman jantman closed this Oct 28, 2017

@jantman jantman removed the unreleased fix label Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment