Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch all exceptions when using pip _internal? #7

Closed
emilburzo opened this issue Sep 30, 2019 · 4 comments · Fixed by #8
Closed

catch all exceptions when using pip _internal? #7

emilburzo opened this issue Sep 30, 2019 · 4 comments · Fixed by #8

Comments

@emilburzo
Copy link

@emilburzo emilburzo commented Sep 30, 2019

Bug Report

With the latest version of pip (19.2.3), versionfinder (and thus awslimitchecker) crashes when running on AWS lambda.

It is because of a recent addition to pip's subversion.py, which doesn't expect sys.stdin to be None

I've opened an issue also at pip, but it might make sense to have a broad catch-all exceptions approach for the internal API, in versionfinder

@jantman

This comment has been minimized.

Copy link
Owner

@jantman jantman commented Oct 9, 2019

@emilburzo Thanks, I'll definitely look into this, but it might be a little while before I can take any action on it.

Since you happened to mention it though... I was unaware (or forgot???) that anyone had gotten awslimitchecker running in Lambda. Is there any chance that you have any code you can share for packaging and/or deployment?

@emilburzo

This comment has been minimized.

Copy link
Author

@emilburzo emilburzo commented Oct 9, 2019

I'll definitely look into this, but it might be a little while before I can take any action on it.

I think that's fine / there's no rush, affected users can either:

  • pin their pip version to a previous release
  • upgrade to the newest pip as soon as it's out (my pip PR got accepted, just needs a release)

Since you happened to mention it though... I was unaware (or forgot???) that anyone had gotten awslimitchecker running in Lambda.

Interesting, I didn't know this was problematic, for me "it just worked" :)

Is there any chance that you have any code you can share for packaging and/or deployment?

It feels pretty basic, but if it helps someone, sure, I can put a sample repo together.

@jantman

This comment has been minimized.

Copy link
Owner

@jantman jantman commented Oct 27, 2019

@emilburzo Apologies for how long it took me to get around to this. I've confirmed a fix for it in #8 and released that as 1.0.0, which is now live on PyPI.

Thank you so much for reporting this!

@emilburzo

This comment has been minimized.

Copy link
Author

@emilburzo emilburzo commented Nov 3, 2019

@jantman thank you!

and also very late, but here's that example awslimitchecker-on-aws-lambda thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.