From 58ed7c0cc919cefe9cf6e2ac854f6dc92b795de7 Mon Sep 17 00:00:00 2001 From: Frank Kong <50030060+Zaperex@users.noreply.github.com> Date: Fri, 3 Nov 2023 13:11:05 -0400 Subject: [PATCH] Fix typo in the dynamic-plugins docs' package.json configurations (#702) * Fix typo in dynamic-plugins.md package.json configurations * Update the `export-dynamic` script to use janus-cli * Update janus-cli version and fix quotations * chore: address review comments Co-authored-by: David Festal --------- Co-authored-by: David Festal Co-authored-by: Tomas Kral Co-authored-by: Nick Boldt --- showcase-docs/dynamic-plugins.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/showcase-docs/dynamic-plugins.md b/showcase-docs/dynamic-plugins.md index 4af59310a..73407102f 100644 --- a/showcase-docs/dynamic-plugins.md +++ b/showcase-docs/dynamic-plugins.md @@ -45,18 +45,18 @@ These recommended changes to the `package.json` are summarized below: ... "scripts": { ... - "export-dynamic": "backstage-cli package export-dynamic-plugin" + "export-dynamic": "janus-cli package export-dynamic-plugin" ... }, ... "dependencies": { ... - "@backstage/backend-plugin-manager": "npm:janus-idp/backend-plugin-manager@0.0.5-janus.0", + "@backstage/backend-plugin-manager": "npm:@janus-idp/backend-plugin-manager@v1.19.6", ... } ... "devDependencies": { - "@janus-idp/cli": "1.1.0 + "@janus-idp/cli": "1.3.1" }, ... "files": [