Skip to content

Janusz
januszm

  • Joined on Jun 21, 2011
Jun 21, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

Now it looks slick 👍 @Salzig what do you think about this pull request?

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

Yes, register_engine plays the 'dispatcher' role in this scenario. Also, this is the case where you might consider using 'underscored' version of m…

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

Notice, you don't need both parameters in the method's signature (v3 uses only app which v4+ uses config)

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

I already use slim-rails with Rails 5. No worries, you can safely use the generic register_engine name for both 4 and 5.

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

Please review parameter naming, you can use app in one version and config in another.

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

@hanachin nice, but you can safely rename register_engine4 to just register_engine since it also servers Rails 5 and maybe new releases (we'll deal…

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

@hanachin re: Fix allow_failures this hasn't been tested by you?

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

@hanachin OK now let's work out that complex if/else statement using line notes.

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

Exactly, it only makes sense in Assets Pipeline. So we need a 'special case' for Rails 3.1 and Rails 3.2 or only for one of those?

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

@hanachin please rebase this branch on top of master and let's see how many errors we'll have after allowing failures for ruby-head

Jun 20, 2016
@januszm
Jun 20, 2016
@januszm
Jun 20, 2016
@januszm
Allow failures for ruby-head
1 commit with 2 additions and 0 deletions
Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#119
@januszm

Good catch @hanachin , if slim-rails has a hard dependency on Rails then, well, let's also allow failures on ruby-head

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

I'll switch to using v3.1.0 until this is resolved.

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#118
@januszm

@hanachin a quite bizarre piece of code. What issue are you trying to resolve here? Can we write it first in some 'pseudo code' to clarify the flow?

Jun 20, 2016
januszm commented on pull request slim-template/slim-rails#115
@januszm

Guys after this merge I get the following error on my previously 'sane' app: slim-rails-656314fb69f0/lib/slim-rails.rb:13:in `block (2 levels) in <…

Jun 10, 2016
januszm commented on pull request slim-template/slim-rails#119
@januszm

Why?

Jun 10, 2016
januszm commented on pull request slim-template/slim-rails#115
@januszm

@hanachin please next time also rebase your changes on top of the master branch. This will help us maintaining a clean and readable history of changes

januszm deleted branch feature/codeclimate_badges at januszm/slim-rails
Jun 10, 2016
Jun 10, 2016
@januszm
januszm deleted branch revert-115-configure-block at slim-template/slim-rails
Jun 10, 2016
Jun 10, 2016
@januszm
Revert "Only access environment directly in configure block"
Jun 10, 2016
@januszm
Revert "Only access environment directly in configure block"
1 commit with 2 additions and 4 deletions
Jun 10, 2016
januszm commented on pull request slim-template/slim-rails#115
@januszm

@Salzig LGTM? there was a typo ;) @hanachin did you run tests locally before uploading those changes here?

Jun 6, 2016
@januszm
Add CodeClimate badges
1 commit with 4 additions and 1 deletion
Jun 6, 2016
januszm deleted branch rails-5 at januszm/slim-rails
Jun 6, 2016
Jun 6, 2016
@januszm
Something went wrong with that request. Please try again.