Skip to content
This repository has been archived by the owner. It is now read-only.

Optimising MConfig #452

Open
psibi opened this issue Jun 1, 2020 · 2 comments
Open

Optimising MConfig #452

psibi opened this issue Jun 1, 2020 · 2 comments

Comments

@psibi
Copy link
Contributor

psibi commented Jun 1, 2020

We currently have defined MConfig which is bunch of IORefs. But looking at the code - it seems that it's not really required. What we are doing currently can be just done via normal records and pure function. Is there any specific reason we are using IORef here ?

Again, I would like to refactor this - but would like to know before working if there is any specific reason for using around 15 plus IORef for doing it ?

@slotThe
Copy link
Contributor

slotThe commented Jun 6, 2020

Looking at the code I get the same impression as you---the IORefs aren't really needed here. I would be in favour of refactoring this.

@jaor
Copy link
Owner

jaor commented Jun 7, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants