Skip to content

/xargo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy bin directory to host sysroot #200

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@FenrirWolf @japaric @phil-opp @ah- @steveklabnik
@FenrirWolf
Copy link
Contributor

FenrirWolf commented Mar 8, 2018

Allows custom targets to use the copy of lld bundled with Rust.

cc rust-lang/rust#48772
@japaric

This comment has been minimized.

Sign in to view
Copy link
Owner

japaric commented Mar 9, 2018

Thanks @FenrirWolf

bors r+

bors bot added a commit that referenced this pull request Mar 9, 2018

@bors
Merge #200 
200: Copy bin directory to host sysroot r=japaric a=FenrirWolf

Allows custom targets to use the copy of `lld` bundled with Rust.

cc rust-lang/rust#48772
Loading status checks…
6e8347d
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors bot commented Mar 9, 2018

Build succeeded

@bors bors bot merged commit 9787b69 into japaric:master Mar 9, 2018
1 check passed

1 check passed

bors Build succeeded
Details
@phil-opp

This comment has been minimized.

Sign in to view
Copy link

phil-opp commented Mar 9, 2018

I just tried it and it seems to work! Thanks a lot @FenrirWolf!

@japaric Could we get a new crates.io release for this?

@FenrirWolf FenrirWolf deleted the FenrirWolf:copy-bin branch Mar 9, 2018

@japaric

This comment has been minimized.

Sign in to view
Copy link
Owner

japaric commented Mar 9, 2018

@phil-opp v0.3.11 is out and has these changes
@phil-opp

This comment has been minimized.

Sign in to view
Copy link

phil-opp commented Mar 9, 2018

Thanks a lot!

This was referenced Mar 9, 2018

Merged
Open
@ah-

This comment has been minimized.

Sign in to view
Copy link

ah- commented Mar 10, 2018

Could you please upload binaries for 0.3.11 to https://github.com/japaric/xargo/releases?
In particular xargo-v0.3.11-x86_64-unknown-linux-musl.tar.gz?

I'm using your install.sh script to pull the latest tag and CI is failing as the tag exists, but binaries don't.

Happy to help doing that as well if you point me in the right direction.
@japaric

This comment has been minimized.

Sign in to view
Copy link
Owner

japaric commented Mar 10, 2018

@ah- done. Linux releases have been uploaded.
@ah-

This comment has been minimized.

Sign in to view
Copy link

ah- commented Mar 10, 2018

That was quick! Thanks, works perfectly again.
@steveklabnik

This comment has been minimized.

Sign in to view
Copy link

steveklabnik commented Mar 10, 2018

I had to update my rust nightly as well as install the new xargo to get this to work, but it works for me too!

@japaric japaric referenced this pull request Mar 10, 2018

Closed

Embedded WG newsletter #1 #58

@phil-opp phil-opp referenced this pull request Mar 13, 2018

Closed

Set Up Rust - Compiling Issue with rlibc #414

@Woyten Woyten referenced this pull request Mar 13, 2018

Merged

Update Cargo.lock #201

bors bot added a commit that referenced this pull request Mar 26, 2018

@bors
Merge #201 
201: Update Cargo.lock r=japaric a=Woyten

Since #200, `Cargo.lock` is considered dirty after Xargo has been built. This is particularly annoying when using Xargo as a Git submodule such as in tock/libtock-rs#18.

This PR updates `Cargo.lock` s.t. it will no longer be considered dirty after building Xargo.
Loading status checks…
da390b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.