Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional AutoDelete options #2

Merged
merged 1 commit into from Jan 17, 2018
Merged

Add additional AutoDelete options #2

merged 1 commit into from Jan 17, 2018

Conversation

@webOSpinn
Copy link
Contributor

@webOSpinn webOSpinn commented Jan 17, 2018

Add additional AutoDelete options so tasks that are occur less frequently remain in the completed list longer.

I have tasks that occur once a year and I would like them to remain in the completed list until the next occurrence of the task is completed. Because of this I've kept the AutoDelete option set to "None" but unfortunately there is no good way to cleanup really old tasks. Extending the AutoDelete option resolves this issue.

Add additional AutoDelete options so tasks that are occur less frequently remain in the completed list longer.
@japf
Copy link
Owner

@japf japf commented Jan 17, 2018

That looks awesome, thank you for submitting the PR 👍

May I ask how did you get the translations?

@webOSpinn
Copy link
Contributor Author

@webOSpinn webOSpinn commented Jan 17, 2018

I'm glad I can help improve the app I depend on everyday 😊

I used Google Translate. I double checked the translations and they appeared to match what was already in the resx files for the translation of 3 months.

@japf japf merged commit ac2ab95 into japf:master Jan 17, 2018
@japf
Copy link
Owner

@japf japf commented Jan 17, 2018

Thank you for the PR !

I plan to ship a 4.8.6 version to the store over the week-end.

webOSpinn referenced this pull request in webOSpinn/2day Jan 18, 2018
Merge pull request #2 from webOSpinn/master
webOSpinn referenced this pull request in webOSpinn/2day Jan 18, 2018
@webOSpinn
Copy link
Contributor Author

@webOSpinn webOSpinn commented Jan 18, 2018

Cool. I look forward to it.

Congratulations on the new job and thank you for releasing the 2Day source code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants