Skip to content

jQuery 1.8.x not working with Jappix Mini #186

Closed
haroldkyle opened this Issue Nov 16, 2012 · 19 comments

4 participants

@haroldkyle

Jappix Mini doesn't work with jQuery 1.8.x, though it works fine with 1.7.2.

Our connection to the the bosh is fine with 1.8.x, but the chat window does not show any chat group history, and the user cannot send messages. Hitting return after typing a message does nothing. Once I rolled back jQuery things worked fine again. There are no JS errors in our console, interestingly.

@camaran
camaran commented Nov 16, 2012

can you share the version with jquery 1.7.2 because from my test not work

@haroldkyle

Not sure I understand. I just git cloned https://github.com/jappix/jappix.git and then used http://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js . I could share other installation details, but that's the gist of what I'm doing. We're using our own installation of node-xmpp-bosh, and I have not tried this on the Jappix boshes.

@camaran
camaran commented Nov 16, 2012

in my installation if i use jquery 1.7.2 not work

@haroldkyle

Unfortunately our installation is behind an htpasswd and still in development, otherwise I'd point you to it. I'll see if I can get a test site up tonight on a different domain. Are you experiencing the same problems as I describe when you use 1.7.2? Or are there errors in the console when Jappix is running in developer mode?

@camaran
camaran commented Nov 16, 2012

how i can enable the developer mode?

@haroldkyle

We're running our own installation of Jappix. We found the <developer>on</developer> setting in /store/conf/main.xml . If you don't have access edit this file directly, I don't believe you can change it because it's not exposed to manager web page. Although I'm not sure everything it does, it increased logging in our browser's console while we diagnosed this issue.

@camaran
camaran commented Nov 16, 2012

you see devchat.chatme.im there is a jappix with jquery 1.8.3 and other jquery update

@haroldkyle

Well, the full Jappix client may be fine, I haven't tested that. But the bug I'm describing is with the Mini chat client.

For me, the Mini chat client is not working at http://chatme.im/ . This is a good example of the problem that I had with jQuery 1.8.2 (which this page also uses).

@camaran
camaran commented Nov 16, 2012

for me not work the jappix full with jquery 1.8.3

@camaran
camaran commented Nov 19, 2012

i think must load jappix mini jquery with noConflict mode for use with other jquery version

@camaran
camaran commented Nov 19, 2012

You see here http://devchat.chatme.im/test.htm i have the two version of jquery

@haroldkyle

Ah I see. I spent a few minutes debugging this but didn't get too far. I noticed that in 1.8.x that some data attributes were not working as selectors, and also (perhaps related) that some of the jQuery "attribute equals selectors" were not working. I noticed that the mini.js usage does not conform to the jQuery API, although I'm not 100% sure this is the problem. But, for instance, mini.js has:

var unknown_entry = jQuery('#jappix_mini a.jm_unknown[data-xid=' + xid + ']');

instead of (note the quotes):

var unknown_entry = jQuery('#jappix_mini a.jm_unknown[data-xid="' + xid + '"]');

I honestly didn't spend enough time on this, but mini.js throws errors for these selectors sometimes, leading the try block to fail, in some cases. I don't think I'll get time to debug this much further before Christmas, but I'd be happy to try to iron some of these things out (if it would help) in the new year.

@camaran
camaran commented Nov 20, 2012

No i think it's a problem of jQuery and html elements with the new version i think is a different code for manage html and broken all jappix (desktop and mini)

@haroldkyle
@mcconnor
mcconnor commented Feb 6, 2013

Hi Harold,

I experience the exact same problems with Jappix Mini and jQuery 1.9.1 (released yesterday) and as far as I know, those problems are there for a while now.

Do you know if something is happening there or have you found any solution for this issue?

Cheers

Frank

@haroldkyle

When I looked at the JS (months ago) it looked in need of pretty significant rewriting. I don't know if anyone has taken on this challenge, but it should be more important as time goes on. Our website hasn't been able to update to a more recent version of jQuery than 1.7.2 because of this issue...

@mcconnor
mcconnor commented Feb 6, 2013

Cheers for getting back to me ... I think I will have a look

@valeriansaliou valeriansaliou pushed a commit that closed this issue Feb 7, 2013
Valérian Saliou fixes #186 a30c819
@mcconnor
mcconnor commented Feb 8, 2013

Thank you very much Valerian, I will try it out very soon :-)

@valeriansaliou
Jappix member

You are welcome. We will update our Jappix.com service soon with a brand new 0.9.2 version including all this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.