Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRCClient _send() method in server.py does not handle broken pipe #119

Closed
strictlymike opened this issue Nov 15, 2016 · 0 comments
Closed

IRCClient _send() method in server.py does not handle broken pipe #119

strictlymike opened this issue Nov 15, 2016 · 0 comments

Comments

@strictlymike
Copy link
Contributor

This results in unwanted exception output in serve_forever(). A localized work-around is to inherit and override _send() to except socket.error and raise self.Disconnect(). Is that an adequate fix for master?
@jaraco jaraco closed this as completed in 48ae49a Nov 15, 2016
jaraco added a commit that referenced this issue Nov 15, 2016
@jaraco
Merge pull request #120 from strictlymike/issue-119
f44460b 
Fixes #119 per comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@strictlymike