Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tags in IRCv3 #62

Closed
jaraco opened this issue Nov 20, 2015 · 6 comments
Closed

support tags in IRCv3 #62

jaraco opened this issue Nov 20, 2015 · 6 comments

Comments

@jaraco
Copy link
Owner

jaraco commented Nov 20, 2015

http://ircv3.net/specs/core/message-tags-3.2.html

twitch chat already using it, but for now i parse them in on_all_raw_messages


@jaraco
Copy link
Owner Author

jaraco commented Nov 20, 2015

Sounds good. Would you be willing to put together a pull request?


Original comment by: Jason R. Coombs

@jaraco
Copy link
Owner Author

jaraco commented Nov 20, 2015

i looked into it before, but its too complicated for me


Original comment by: Mihail Latyshov

@jaraco jaraco closed this as completed Nov 20, 2015
@jaraco
Copy link
Owner Author

jaraco commented Nov 20, 2015

I would be happy to help, but I don't have the time to be able to design and implement this feature from scratch.

Let's start from the beginning; can you document what sort of user experience you'd like to see from the library? For example, if the feature were implemented how would you propose that twitch solicit the tags from the ServerConnection? Would tags be associated with any Event?


Original comment by: Jason R. Coombs

@jaraco
Copy link
Owner Author

jaraco commented Nov 20, 2015

can you document what sort of user experience you'd like to see from the library?

nothing fancy, just tags inside event

i would use it like this

def on_pubmsg(self, connection, event):
    logging.info(event.tags)

tags will be just dict

Would tags be associated with any Event?

if there are tags, event will have tags inside, otherwise just None

but as i said, i already use them via on_all_raw_messages, so this issue is just a proposal, nothing else


Original comment by: Mihail Latyshov

@jaraco
Copy link
Owner Author

jaraco commented Nov 20, 2015

I added a Pull request to handle the IRCv3 tags.


Original comment by: kimen91

@jaraco
Copy link
Owner Author

jaraco commented Nov 20, 2015

Pull Request #34 has been released as 12.2. Please test and re-open if that doesn't provide the solution. Huge thanks to @kimen91.


Original comment by: Jason R. Coombs

jaraco pushed a commit that referenced this issue Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant